Difference between revisions of "Commiting Changes"

From ReactOS Wiki
Jump to: navigation, search
m (Maintainers)
m
 
(3 intermediate revisions by one other user not shown)
Line 3: Line 3:
 
==For newbies==
 
==For newbies==
 
To commit your changes into the repository, follow these steps:
 
To commit your changes into the repository, follow these steps:
# ''Fork'' the ReactOS repository into your own GitHub account
+
# If you don't have [http://github.com/ GitHub] account, create it first
 +
# ''Fork'' the [http://github.com/reactos/reactos ReactOS repository] into your own GitHub account
 
# Make sure you set up your ''full name'' and correct ''public e-mail'' in your [https://github.com/settings/profile account settings] (this is required by our [https://github.com/reactos/reactos/blob/master/CONTRIBUTING.md#rules-and-recommendations contributing rules])
 
# Make sure you set up your ''full name'' and correct ''public e-mail'' in your [https://github.com/settings/profile account settings] (this is required by our [https://github.com/reactos/reactos/blob/master/CONTRIBUTING.md#rules-and-recommendations contributing rules])
# ''Commit'' changes in your new forked repository following our [https://github.com/reactos/reactos/blob/master/.gitmessage commit message style]
+
# ''Commit'' changes in your new forked repository following our [https://github.com/reactos/reactos/blob/master/.gitmessage commit message style].
## If you already have a pending Pull Request and you want to create another, you should create a ''new branch'' in your forked repository and commit changes to it
+
## Each pull request needs a unique branch, so it is recommended to always create a new branch!
 +
## Updates to the pull request can be done by committing to this branch again (and pushing it)
 
# Create a ''Pull Request'' from your branch using either GitHub interface or [https://desktop.github.com/ GitHub Desktop App]
 
# Create a ''Pull Request'' from your branch using either GitHub interface or [https://desktop.github.com/ GitHub Desktop App]
  
Line 15: Line 17:
 
There are known maintainers for some modules and parts of the ReactOS:
 
There are known maintainers for some modules and parts of the ReactOS:
  
* https://github.com/reactos/reactos/blob/master/MAINTAINERS
+
* https://github.com/reactos/reactos/blob/master/CODEOWNERS
  
 
Once you have created a Pull Request, you may want to communicate with module maintainer for review and merge your code.
 
Once you have created a Pull Request, you may want to communicate with module maintainer for review and merge your code.
  
 
==See also==
 
==See also==
For further details read [[ReactOS Git For Dummies]] article.
+
* For further details read [[ReactOS Git For Dummies]] article.
 +
* You may also refer to older article [[Submitting Patches]].
  
  
 
[[Category: Tutorial]]
 
[[Category: Tutorial]]

Latest revision as of 12:50, 24 January 2022

Since the migration to GitHub, contributing to the project become even easier!

For newbies

To commit your changes into the repository, follow these steps:

  1. If you don't have GitHub account, create it first
  2. Fork the ReactOS repository into your own GitHub account
  3. Make sure you set up your full name and correct public e-mail in your account settings (this is required by our contributing rules)
  4. Commit changes in your new forked repository following our commit message style.
    1. Each pull request needs a unique branch, so it is recommended to always create a new branch!
    2. Updates to the pull request can be done by committing to this branch again (and pushing it)
  5. Create a Pull Request from your branch using either GitHub interface or GitHub Desktop App

For developers

Please follow Workflow guide.

Maintainers

There are known maintainers for some modules and parts of the ReactOS:

Once you have created a Pull Request, you may want to communicate with module maintainer for review and merge your code.

See also