Difference between revisions of "User talk:Lone Rifle"

From ReactOS Wiki
Jump to: navigation, search
(copied table and added remaining data for coverity errors solved)
(Removing all content from page)
 
(7 intermediate revisions by 5 users not shown)
Line 1: Line 1:
Some more suggestions for fixed Coverity Errors (taken from Ros-Diffs Mailing List):
 
  
*[cwittich] '''36411''': don't free memory which is not allocated yet Fix for Coverity error CID: '''789'''.
 
*[cwittich] '''36412''': overrun of static array Fix for Coverity error CID: '''548'''.
 
*[cwittich] '''36413''': overrun of static array Fix for Coverity error CID: '''546 + 547'''.
 
*[fireball] '''36414''': - Preinitialize ValueData with NULL. - Fix for Coverity error CID: '''772'''.
 
*[cwittich] '''36415''': overrun of static array Fix for Coverity error CID: '''552'''
 
*[cwittich] '''36416''': overrun of static array Fix for Coverity error CID: '''532'''
 
*[fireball] '''36417''': - The check for SystemHive being non-NULL is meaningless, because CmpInitializeHive is already checked for failure earlier, and in success case it returns a valid Hive. - Fix for Coverity error CID: '''280'''
 
*[cwittich] '''36418''': overrun of static array Fix for Coverity error CID: '''529'''
 
*[arty] '''36419''': Fix possible overrun of the last byte of dbuf (coverity '''552''').
 
*[arty] '''36420''': This bug could've caused mayhem in the icon cache. (coverity '''790''').
 
*[arty] '''36421''': Fix a legitimate overrun in _widths (coverity '''575'''), and try not to be as clever.
 
*[arty] '''36422''': Count the end of the szApplicationName in the right units. (coverity '''551''').
 
*[cwittich] '''36434''': return correct value in SETUPAPI_GetCurrentHwProfile Fix for Coverity error CID: '''782'''
 
*[gedmurphy] '''36435''': Don't risk a negative array subscript. Fixes our one and only REVERSE_NEGATIVE error Fix for Coverity error CID: '''766'''
 
*[arty] '''36479''': Fix my copypasta spotted by (coverity '''1294''')
 
*[arty] '''36480''': Fix leaks reported by coverity '''612-615'''. In each case, it'd be safe to free NULL, and failure to allocate isn't the only dropthrough case, leading to conversion buffer leaks.
 
*[sginsberg] '''36483''': - FsRtlBalanceReads: Fail if we are out of memory instead of dereferencing null - Fix for Coverity error CID: '''465'''
 
*[cwittich] '''36485''': check for value > 0 before using it as array index Fix for Coverity error CID: '''438'''
 
*[sginsberg] '''36486''': - Only dereference the KCB if we know it exists - Fix for Coverity error CID: '''279'''
 
 
 
Copied table and added remaining data:
 
 
{| class="wikitable"
 
|-
 
! Coverity Error ID
 
! Correcting Trunk Revision
 
|-
 
| 9
 
| r36491
 
|-
 
| 29
 
| r36518
 
|-
 
| 33
 
| r36523
 
|-
 
| 85
 
| r36538
 
|-
 
| 155
 
| r36489
 
|-
 
| 279
 
| r36486
 
|-
 
| 280
 
| r36417
 
|-
 
| 388
 
| r36528
 
|-
 
| 389
 
| r36526
 
|-
 
| 398
 
| r36571
 
|-
 
| 438
 
| r36485
 
|-
 
| 458
 
| r36527
 
|-
 
| 464
 
| r36490
 
|-
 
| 465
 
| r36483
 
|-
 
| 469
 
| r36487
 
|-
 
| 486
 
| r36578
 
|-
 
| 487
 
| r36578
 
|-
 
| 529
 
| r36418
 
|-
 
| 532
 
| r36416
 
|-
 
| 538
 
| r36584
 
|-
 
| 546
 
| r36413
 
|-
 
| 547
 
| r36413
 
|-
 
| 548
 
| r36412
 
|-
 
| 551
 
| r36422
 
|-
 
| 552
 
| r36415+r36419
 
|-
 
| 575
 
| r36421
 
|-
 
| 600
 
| r36525
 
|-
 
| 601
 
| r36572
 
|-
 
| 612
 
| r36480
 
|-
 
| 613
 
| r36480
 
|-
 
| 614
 
| r36480
 
|-
 
| 615
 
| r36480
 
|-
 
| 652
 
| r36524
 
|-
 
| 680
 
| r36579
 
|-
 
| 761
 
| r36569
 
|-
 
| 766
 
| r36435
 
|-
 
| 767
 
| r36519
 
|-
 
| 768
 
| r36519
 
|-
 
| 769
 
| r36519
 
|-
 
| 770
 
| r36519
 
|-
 
| 772
 
| r36414
 
|-
 
| 773
 
| r36494
 
|-
 
| 775
 
| r36410
 
|-
 
| 782
 
| r36434
 
|-
 
| 789
 
| r36411
 
|-
 
| 790
 
| r36520
 
|-
 
| 1293
 
| r36573
 
|-
 
| 1294
 
| r36479
 
|}
 
 
48/1417 Coverity Errors solved (slightly above 3%)
 

Latest revision as of 11:58, 22 August 2009