Difference between revisions of "User talk:Lone Rifle"

From ReactOS Wiki
Jump to: navigation, search
(more suggestions for fixed Coverity Errors)
 
(a few more added)
Line 13: Line 13:
 
*[arty] '''36421''': Fix a legitimate overrun in _widths (coverity '''575'''), and try not to be as clever.
 
*[arty] '''36421''': Fix a legitimate overrun in _widths (coverity '''575'''), and try not to be as clever.
 
*[arty] '''36422''': Count the end of the szApplicationName in the right units. (coverity '''551''').
 
*[arty] '''36422''': Count the end of the szApplicationName in the right units. (coverity '''551''').
 +
*[cwittich] '''36434''': return correct value in SETUPAPI_GetCurrentHwProfile Fix for Coverity error CID: '''782'''
 +
*[gedmurphy] '''36435''': Don't risk a negative array subscript. Fixes our one and only REVERSE_NEGATIVE error Fix for Coverity error CID: '''766'''
 +
*[arty] '''36479''': Fix my copypasta spotted by (coverity '''1294''')
 +
*[arty] '''36480''': Fix leaks reported by coverity '''612-615'''. In each case, it'd be safe to free NULL, and failure to allocate isn't the only dropthrough case, leading to conversion buffer leaks.
 +
*[sginsberg] '''36483''': - FsRtlBalanceReads: Fail if we are out of memory instead of dereferencing null - Fix for Coverity error CID: '''465'''
 +
*[cwittich] '''36485''': check for value > 0 before using it as array index Fix for Coverity error CID: '''438'''
 +
*[sginsberg] '''36486''': - Only dereference the KCB if we know it exists - Fix for Coverity error CID: '''279'''

Revision as of 08:52, 29 September 2008

Some more suggestions for fixed Coverity Errors (taken from Ros-Diffs Mailing List):

  • [cwittich] 36411: don't free memory which is not allocated yet Fix for Coverity error CID: 789.
  • [cwittich] 36412: overrun of static array Fix for Coverity error CID: 548.
  • [cwittich] 36413: overrun of static array Fix for Coverity error CID: 546 + 547.
  • [fireball] 36414: - Preinitialize ValueData with NULL. - Fix for Coverity error CID: 772.
  • [cwittich] 36415: overrun of static array Fix for Coverity error CID: 552
  • [cwittich] 36416: overrun of static array Fix for Coverity error CID: 532
  • [fireball] 36417: - The check for SystemHive being non-NULL is meaningless, because CmpInitializeHive is already checked for failure earlier, and in success case it returns a valid Hive. - Fix for Coverity error CID: 280
  • [cwittich] 36418: overrun of static array Fix for Coverity error CID: 529
  • [arty] 36419: Fix possible overrun of the last byte of dbuf (coverity 552).
  • [arty] 36420: This bug could've caused mayhem in the icon cache. (coverity 790).
  • [arty] 36421: Fix a legitimate overrun in _widths (coverity 575), and try not to be as clever.
  • [arty] 36422: Count the end of the szApplicationName in the right units. (coverity 551).
  • [cwittich] 36434: return correct value in SETUPAPI_GetCurrentHwProfile Fix for Coverity error CID: 782
  • [gedmurphy] 36435: Don't risk a negative array subscript. Fixes our one and only REVERSE_NEGATIVE error Fix for Coverity error CID: 766
  • [arty] 36479: Fix my copypasta spotted by (coverity 1294)
  • [arty] 36480: Fix leaks reported by coverity 612-615. In each case, it'd be safe to free NULL, and failure to allocate isn't the only dropthrough case, leading to conversion buffer leaks.
  • [sginsberg] 36483: - FsRtlBalanceReads: Fail if we are out of memory instead of dereferencing null - Fix for Coverity error CID: 465
  • [cwittich] 36485: check for value > 0 before using it as array index Fix for Coverity error CID: 438
  • [sginsberg] 36486: - Only dereference the KCB if we know it exists - Fix for Coverity error CID: 279