Submitting Patches

From ReactOS Wiki
Revision as of 02:20, 29 October 2007 by ThePhysicist (talk | contribs) (Submitting a patch to the project)
Jump to: navigation, search

Submitting a patch to the project

Since ReactOS does not have a definite maintainer for each section of the code, you should open a new bug in bugzilla and apply your patch. Set the severity level to major to draw the developers attention to the patch. If you are unsure about something, talk to some dev in the #reactos irc channel.

Test your patch

Thoroughly check that your change works as intended. Test your changes with the latest code from SVN. Something may have changed in the latest code that either breaks your change or causes your change to break something else. Make sure that ReactOS can still boot and that any applications or systems that may be affected by your change still run properly.

Preparing the patch

Make sure that your patch is against the latest code from SVN. Where you have made changes to an existing source file, you will use diff to obtain a file that contains only the changes that you have made: Make sure you have svn on your system (svn.exe on Windows). If you use Windows and don't have this tool, you can obtain it from (remember to put the subversion directory in your path). To create the patch:

  • cd "top-directory-for-all-changed-files"
  • svn diff > mypatch.diff

or use TortoiseSVN, which provides easy to use context menus in Windows Explorer.

Zip all new files and diffs to existing files and send them to the person that will commit the changes to SVN or submit the patch to Bugzilla.

  • You also need to provide your name and mail address! Patches from unknown authors are not accepeted!!!