ChangeLog-0.3.7

Remember the format for changelogs! * Description (Developer names, bug #x)

Developer names are to be in brackets, ONLY IF you have a page on the wiki

Review the Biographies page to see if you qualify for a page on the wiki

This is the changelog for ReactOS™ version 0.3.7 (released *wouldn't you like to know*), an open-source operating system designed to be binary executable- and device driver-compatible with Microsoft™ Windows NT™ and subsequent Microsoft operating systems such as Windows 2000™ and Windows XP™. ReactOS is written by the ReactOS development team, and the last previous version of ReactOS was version 0.3.6 (released 6 August, 2008).

Core

Kernel Mode Drivers

AFD

• Remove a hack not needed now that we don't get bad IRPs (Cameron Gutman)
• Always set Irp->IoStatus.Status in UnlockAndMaybeComplete (Cameron Gutman)
• Make sure we don't fail without completing the IRP (Cameron Gutman)
• Fix 12 memory leaks (Cameron Gutman)
• Return STATUS_INVALID_PARAMETER if we get passed a NULL ConnectionObject (Cameron Gutman)
• Check for a NULL FCB before accessing it (Cameron Gutman)
• Set the MDL to NULL after we free it so it doesn't get freed again (Cameron Gutman)
• Fail if LockBuffers() fails (Cameron Gutman)
• FCB->Recv.Window and FCB->Send.Window must be allocated before returning STATUS_SUCCESS (Cameron Gutman)
• Make sure MakeSocketIntoConnection() completed successfully (Cameron Gutman)
• Make sure WarmSocketForConnection() completed successfully (Cameron Gutman)
• Don't continue if TdiBuildNullConnectionInfoInPlace() fails (Cameron Gutman)
• Make sure we have a non-NULL TargetAddress before calling TdiSendDatagram() (Cameron Gutman)
• Free the MDL if we fail (Cameron Gutman)
• Use _SEH_YIELD (Cameron Gutman)
• Check for FCB->TdiDeviceName.Buffer before attempting to access it (Cameron Gutman)
• Move memory freeing to ListenComplete (Cameron Gutman)
• Don't crash if the buffers are already freed (Cameron Gutman)
• Set Buf to NULL so we don't try to free it again later (Cameron Gutman)
• Fix a typo resulting in any call to AfdGetSockOrPeerName with Local set to FALSE to return STATUS_NO_MEMORY (Cameron Gutman)
• Move SocketAcquireStateLock out of SEH (Cameron Gutman)
• Make sure we successfully allocated ConnectionReturnInfo and ConnectionCallInfo (Cameron Gutman)
• Make sure ObReferenceObjectByHandle was successful (Cameron Gutman)
• Call SocketStateUnlock before returning (Cameron Gutman)
• Don't complete the IRP again in the completion routine (Cameron Gutman)
• Change STATUS_UNSUCCESSFUL to STATUS_FILE_CLOSED (Cameron Gutman)
• Move the Irp->Cancel check after SocketAcquireStateLock to fix a possible crash (Cameron Gutman)
• Change STATUS_INVALID_PARAMETER to STATUS_FILE_CLOSED (Cameron Gutman)
• Move SocketAcquireStateLock in front of the check for a NULL return from LockRequest to prevent another possible crash (Cameron Gutman)
• Call MmProbeAndLockPages for SysMdl (Cameron Gutman)
• Use the correct IOCTL (Cameron Gutman)
• Make sure we don't complete with STATUS_SUCCESS if MmMapLockedPages fails (Cameron Gutman)
• Use MmGetSystemAddressForMdlSafe instead of MmMapLockedPages (Cameron Gutman)
• Fix a bug that resulted in the status getting changed if TdiQueryInformation failed (Cameron Gutman)
• Use FCB->Connection.Object instead of FCB->AddressFile.Object (Cameron Gutman)
• Enclose MmProbeAndLockPages in SEH (Cameron Gutman)
• Return a more accurate status (STATUS_INVALID_PARAMETER) than STATUS_UNSUCCESSFUL when a parameter is NULL (Cameron Gutman)
• Make sure FCB->AddressFrom is non-NULL (Cameron Gutman)
• Make sure FCB->RemoteAddress is non-NULL (Cameron Gutman)
• Make sure IPAddr is non-NULL (Cameron Gutman)
• Fail if MmProbeAndLockPages doesn't succeed (Cameron Gutman)
• Fail if IoAllocateMdl returns NULL (Cameron Gutman)
• Skip ObReferenceObjectByHandle if HandleArray[i].Handle is NULL (Cameron Gutman)
• Fail if ObReferenceObjectByHandle didn't succeed (Cameron Gutman)
• Set *ConnectionInfo to NULL if we can't allocate memory for ConnInfo (Cameron Gutman)
• Fail if DatagramRecv->Address is NULL (Cameron Gutman)
• Add some missing calls to PollReeval (Cameron Gutman)
• Move an existing PollReeval so it always gets called (Cameron Gutman)
• Set Handle to NULL so we don't try to close it later (Cameron Gutman)
• Free the address we've previously allocated if needed (Cameron Gutman)
• Check if MakeSocketIntoConnection succeeded (Cameron Gutman)
• Check if TaCopyTransportAddress succeeded (Cameron Gutman)
• Check if TdiBuildNullConnectionInfo completed successfully (Cameron Gutman)
• Fail if we can't allocate Qelt (Cameron Gutman)
• Change the status to STATUS_SUCCESS if TdiReceive returns STATUS_PENDING (Cameron Gutman)
• Make sure we successfully allocated memory (Cameron Gutman)

TCPIP

• Check to see if the ZwEnumerateKey call succeeded with the larger buffer and continue if possible (Cameron Gutman)
• Don't continue if OpenRegistryKey fails (Cameron Gutman)
• Fail if we can't allocate memory (Cameron Gutman)
• Fix a memory leak (Cameron Gutman)
• Resize the buffer if STATUS_BUFFER_OVERFLOW is returned (Cameron Gutman)
• Close the handle on failure (Cameron Gutman)
• Always set Irp->IoStatus.Status (Cameron Gutman)
• Clear the cancel routine only when completing (Cameron Gutman)
• Fix IRP cancellation (Cameron Gutman, bug 3309)
• Check that we successfully allocated memory (Cameron Gutman)
• Return TDI_NO_RESOURCES instead of STATUS_NO_MEMORY (Cameron Gutman)
• Return TDI_NO_RESOURCES instead of TDI_INVALID_REQUEST when we can't allocate memory (Cameron Gutman)
• Use NewBuf instead of Data so we actually use the buffer we allocate (Cameron Gutman)
• Check status from RawIPStartup, UDPStartup, and TCPStartup (Cameron Gutman)
• Make sure we successfully allocated memory (Cameron Gutman)
• Return the actual status not NDIS_STATUS_SUCCESS always (Cameron Gutman)

NDIS

• Returning STATUS_BUFFER_OVERFLOW is ok also since we're only trying to get DriverKeyLength (Cameron Gutman)
• Initially set PoolHandle, ConfigurationHandle, KeyHandle, and Filter to NULL (Cameron Gutman)
• Initially set PortOffset to 0 (Cameron Gutman)
• Fix 9 memory leaks (Cameron Gutman)
• Don't return NDIS_STATUS_SUCCESS when we really failed (Cameron Gutman)
• Initially set Packet to NULL (Cameron Gutman)
• Initially set NdisProtocolHandle to NULL (Cameron Gutman)
• Accept STATUS_SUCCESS also as done in config.c (Cameron Gutman)
• Set ParameterValue to NULL on failure (Cameron Gutman)
• Fix a possible crash in the cleanup code (Cameron Gutman)
• Handle AllocatedResources and AllocatedResourcesTranslated separately (Cameron Gutman)
• Fix 4 handle leaks (Cameron Gutman)
• Remove the adapter from the global adapter list if we fail (Cameron Gutman)
• We must call MiniQueueWorkItem while holding a spin lock (Cameron Gutman)
• Call MiniportQueryInformation at the correct IRQL (Cameron Gutman)
• Call MiniportSetInformation at the correct IRQL (Cameron Gutman)
• Call QueryInformationComplete at the correct IRQL (Cameron Gutman)
• Call SetInformationComplete at the correct IRQL (Cameron Gutman)
• Call ProtocolRequestComplete at the correct IRQL (Cameron Gutman)
• Call ProtocolSendComplete at the correct IRQL (Cameron Gutman)
• We must call MiniDequeueWorkItem while holding a spin lock (Cameron Gutman)
• Call MiniportTransferData at DISPATCH_LEVEL (Cameron Gutman)
• Fix a possible crash if Buffer is NULL (Cameron Gutman)
• Use MmGetSystemAddressForMdl instead of MmGetMdlVirtualAddress (Cameron Gutman)
• Implement NdisDprAllocatePacket (Cameron Gutman)
• Implement NdisDprAllocatePacketNonInterlocked (Cameron Gutman)
• Implement NdisDprFreePacket (Cameron Gutman)
• Implement NdisDprFreePacketNonInterlocked (Cameron Gutman)
• Call KeAcquireSpinLockAtDpcLevel instead of KeAcquireSpinLock when possible (Cameron Gutman)
• Don't hold the spin lock as long in MiniportDpc (Cameron Gutman)
• Queue a work item to do our work that was previously done in MiniportDpc so Send/SendPackets gets called at the correct IRQL (Cameron Gutman)
• Call a serialized miniport's Send/SendPackets handler at DISPATCH_LEVEL (Cameron Gutman)

Static Libraries

IP

• Release the spin lock before returning (Cameron Gutman)
• Fix 7 memory leaks (Cameron Gutman)
• Complete with the correct status (Cameron Gutman)
• Don't handle OSK_EINPROGRESS since TCPTranslateError already has done the conversion to STATUS_PENDING (Cameron Gutman)
• Set UDPInitialized to FALSE at the end of UDPShutdown (Cameron Gutman)
• Fail if we didn't successfully add the header (Cameron Gutman)
• Move the NULL check immediately after the memory is allocated (Cameron Gutman)
• Fail if PrepareARPPacket returned NULL (Cameron Gutman)
• Make PortsStartup return NTSTATUS so we can make sure memory allocated succeeded (Cameron Gutman)
• Change the callers of PortsStartup to check the return status (Cameron Gutman)
• Pass the status we were given to the completion routine (Cameron Gutman)

Win32™ Personality

Control panel applets

Ncpa

• Fall back on NameServer value in TCPIP\Parameters if interface for adapter doesnt exist in registry. (Michael Martin, bug #2392)

Win32™ Libraries

MSAFD

• Handle STATUS_INSUFFICIENT_RESOURCES (Cameron Gutman)
• Handle STATUS_REMOTE_NOT_LISTENING (Cameron Gutman)
• Use Status instead of IOSB.Status in some cases (Cameron Gutman)
• Handle STATUS_BUFFER_TOO_SMALL (Cameron Gutman)
• Handle STATUS_NO_MEMORY (Cameron Gutman)
• Handle STATUS_FILE_CLOSED (Cameron Gutman)
• Handle STATUS_INVALID_PARAMETER (Cameron Gutman)