[ros-diffs] [sir_richard] 49771: [NTOS]: Errr... wow! Another one caught by ARM GCC. I can swear x86 GCC used to catch these. Did someone change warning settings? Anyhow, fix a *f++ which increments the pointe...

sir_richard at svn.reactos.org sir_richard at svn.reactos.org
Wed Nov 24 14:47:08 UTC 2010


Author: sir_richard
Date: Wed Nov 24 14:47:08 2010
New Revision: 49771

URL: http://svn.reactos.org/svn/reactos?rev=49771&view=rev
Log:
[NTOS]: Errr... wow! Another one caught by ARM GCC. I can swear x86 GCC used to catch these. Did someone change warning settings? Anyhow, fix a *f++ which increments the pointer, not the value INSIDE the pointer (*f)++. Fixes MiDeleteSystemPageableVm.

Modified:
    trunk/reactos/ntoskrnl/mm/ARM3/virtual.c

Modified: trunk/reactos/ntoskrnl/mm/ARM3/virtual.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/virtual.c?rev=49771&r1=49770&r2=49771&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] Wed Nov 24 14:47:08 2010
@@ -146,7 +146,7 @@
                 ASSERT(Pfn1->u1.WsIndex == 0);
                 
                 /* Actual valid, legitimate, pages */
-                if (ValidPages) *ValidPages++;
+                if (ValidPages) (*ValidPages)++;
                 
                 /* Get the page table entry */
                 PageTableIndex = Pfn1->u4.PteFrame;
@@ -305,7 +305,8 @@
                          IN ULONG_PTR EndingAddress,
                          IN PMMVAD Vad)
 {
-    PMMPTE PointerPte, PointerPde, PrototypePte, LastPrototypePte;
+    PMMPTE PointerPte, PrototypePte, LastPrototypePte;
+    PMMPDE PointerPde;
     MMPTE TempPte;
     PEPROCESS CurrentProcess;
     KIRQL OldIrql;
@@ -1099,7 +1100,8 @@
                     OUT PVOID *NextVa)
 {
 
-    PMMPTE PointerPte, PointerPde;
+    PMMPTE PointerPte;
+    PMMPDE PointerPde;
     MMPTE TempPte;
     BOOLEAN DemandZeroPte = TRUE, ValidPte = FALSE;
     ULONG State = MEM_RESERVE, Protect = 0, LockChange;




More information about the Ros-diffs mailing list