[ros-diffs] [tkreuzer] 49708: [NTOSKRNL] Don't include initguid.h in a global header. It causes the guids to be generated in every object file, using 16 bytes per guid. We were lucky that the linker seemed to ...

tkreuzer at svn.reactos.org tkreuzer at svn.reactos.org
Mon Nov 22 14:08:42 UTC 2010


Author: tkreuzer
Date: Mon Nov 22 14:08:41 2010
New Revision: 49708

URL: http://svn.reactos.org/svn/reactos?rev=49708&view=rev
Log:
[NTOSKRNL]
Don't include initguid.h in a global header. It causes the guids to be generated in every object file, using 16 bytes per guid. We were lucky that the linker seemed to detect duplicates, so that the resulting image size isn't affected. Add a new file guid.c, that only contains the guids.

Added:
    branches/cmake-bringup/ntoskrnl/po/guid.c   (with props)
Modified:
    branches/cmake-bringup/ntoskrnl/CMakeLists.txt
    branches/cmake-bringup/ntoskrnl/include/internal/po.h

Modified: branches/cmake-bringup/ntoskrnl/CMakeLists.txt
URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/ntoskrnl/CMakeLists.txt?rev=49708&r1=49707&r2=49708&view=diff
==============================================================================
--- branches/cmake-bringup/ntoskrnl/CMakeLists.txt [iso-8859-1] (original)
+++ branches/cmake-bringup/ntoskrnl/CMakeLists.txt [iso-8859-1] Mon Nov 22 14:08:41 2010
@@ -215,6 +215,7 @@
     ob/obsecure.c
     ob/obwait.c
     po/events.c
+    po/guid.c
     po/poshtdwn.c
     po/povolume.c
     po/power.c

Modified: branches/cmake-bringup/ntoskrnl/include/internal/po.h
URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/ntoskrnl/include/internal/po.h?rev=49708&r1=49707&r2=49708&view=diff
==============================================================================
--- branches/cmake-bringup/ntoskrnl/include/internal/po.h [iso-8859-1] (original)
+++ branches/cmake-bringup/ntoskrnl/include/internal/po.h [iso-8859-1] Mon Nov 22 14:08:41 2010
@@ -6,7 +6,7 @@
 * PROGRAMMERS:     Alex Ionescu (alex.ionescu at reactos.org)
 */
 
-#include "initguid.h"
+#include <guiddef.h>
 #include <poclass.h>
 
 //

Added: branches/cmake-bringup/ntoskrnl/po/guid.c
URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/ntoskrnl/po/guid.c?rev=49708&view=auto
==============================================================================
--- branches/cmake-bringup/ntoskrnl/po/guid.c (added)
+++ branches/cmake-bringup/ntoskrnl/po/guid.c [iso-8859-1] Mon Nov 22 14:08:41 2010
@@ -1,0 +1,4 @@
+
+#include <wdm.h>
+#include <initguid.h>
+#include <poclass.h>

Propchange: branches/cmake-bringup/ntoskrnl/po/guid.c
------------------------------------------------------------------------------
    svn:eol-style = native




More information about the Ros-diffs mailing list