[ros-diffs] [mpiulachs] 33588: - small fix

mpiulachs at svn.reactos.org mpiulachs at svn.reactos.org
Sun May 18 18:01:35 CEST 2008


Author: mpiulachs
Date: Sun May 18 11:01:34 2008
New Revision: 33588

URL: http://svn.reactos.org/svn/reactos?rev=33588&view=rev
Log:
- small fix

Modified:
    trunk/irc/TechBot/TechBot.Commands.Common/Base/BugCommand.cs
    trunk/irc/TechBot/TechBot.Commands.Common/HResultCommand.cs
    trunk/irc/TechBot/TechBot.Commands.Common/NtStatusCommand.cs
    trunk/irc/TechBot/TechBot.Commands.Common/WMCommand.cs
    trunk/irc/TechBot/TechBot.Commands.Common/WinerrorCommand.cs
    trunk/irc/TechBot/TechBot.Library/Commands/HelpCommand.cs

Modified: trunk/irc/TechBot/TechBot.Commands.Common/Base/BugCommand.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Commands.Common/Base/BugCommand.cs?rev=33588&r1=33587&r2=33588&view=diff
==============================================================================
--- trunk/irc/TechBot/TechBot.Commands.Common/Base/BugCommand.cs [iso-8859-1] (original)
+++ trunk/irc/TechBot/TechBot.Commands.Common/Base/BugCommand.cs [iso-8859-1] Sun May 18 11:01:34 2008
@@ -20,7 +20,7 @@
 
         public override void ExecuteCommand()
         {
-            if (Parameters == null)
+            if (string.IsNullOrEmpty(BugID))
             {
                 Say("Please provide a valid bug number.");
             }

Modified: trunk/irc/TechBot/TechBot.Commands.Common/HResultCommand.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Commands.Common/HResultCommand.cs?rev=33588&r1=33587&r2=33588&view=diff
==============================================================================
--- trunk/irc/TechBot/TechBot.Commands.Common/HResultCommand.cs [iso-8859-1] (original)
+++ trunk/irc/TechBot/TechBot.Commands.Common/HResultCommand.cs [iso-8859-1] Sun May 18 11:01:34 2008
@@ -19,7 +19,7 @@
 
 		public override void ExecuteCommand()
 		{
-            if (Text == null)
+            if (string.IsNullOrEmpty(Text))
             {
                 Say("Please provide a valid HRESULT value.");
             }

Modified: trunk/irc/TechBot/TechBot.Commands.Common/NtStatusCommand.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Commands.Common/NtStatusCommand.cs?rev=33588&r1=33587&r2=33588&view=diff
==============================================================================
--- trunk/irc/TechBot/TechBot.Commands.Common/NtStatusCommand.cs [iso-8859-1] (original)
+++ trunk/irc/TechBot/TechBot.Commands.Common/NtStatusCommand.cs [iso-8859-1] Sun May 18 11:01:34 2008
@@ -19,7 +19,7 @@
 
 		public override void ExecuteCommand()
 		{
-            if (Text == null)
+            if (string.IsNullOrEmpty(Text))
             {
                 Say("Please provide a valid NTSTATUS value.");
             }

Modified: trunk/irc/TechBot/TechBot.Commands.Common/WMCommand.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Commands.Common/WMCommand.cs?rev=33588&r1=33587&r2=33588&view=diff
==============================================================================
--- trunk/irc/TechBot/TechBot.Commands.Common/WMCommand.cs [iso-8859-1] (original)
+++ trunk/irc/TechBot/TechBot.Commands.Common/WMCommand.cs [iso-8859-1] Sun May 18 11:01:34 2008
@@ -26,7 +26,7 @@
 
 		public override void ExecuteCommand()
 		{
-            if (WMText == null)
+            if (string.IsNullOrEmpty(WMText))
             {
                 Say("Please provide a valid window message value or name.");
 

Modified: trunk/irc/TechBot/TechBot.Commands.Common/WinerrorCommand.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Commands.Common/WinerrorCommand.cs?rev=33588&r1=33587&r2=33588&view=diff
==============================================================================
--- trunk/irc/TechBot/TechBot.Commands.Common/WinerrorCommand.cs [iso-8859-1] (original)
+++ trunk/irc/TechBot/TechBot.Commands.Common/WinerrorCommand.cs [iso-8859-1] Sun May 18 11:01:34 2008
@@ -19,7 +19,7 @@
 
 		public override void ExecuteCommand()
 		{
-            if (Text == null)
+            if (string.IsNullOrEmpty(Text))
             {
                 Say("Please provide a valid System Error Code value.");
             }

Modified: trunk/irc/TechBot/TechBot.Library/Commands/HelpCommand.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Commands/HelpCommand.cs?rev=33588&r1=33587&r2=33588&view=diff
==============================================================================
--- trunk/irc/TechBot/TechBot.Library/Commands/HelpCommand.cs [iso-8859-1] (original)
+++ trunk/irc/TechBot/TechBot.Library/Commands/HelpCommand.cs [iso-8859-1] Sun May 18 11:01:34 2008
@@ -7,8 +7,6 @@
     [Command("help", Help = "!help or !help -name:[CommandName]", Description = "Shows this help , type 'help -name:[CommandName]'")]
 	public class HelpCommand : Command
 	{
-        private string m_CommandName = null;
-
         public HelpCommand()
 		{
 		}
@@ -22,7 +20,7 @@
 
         public override void ExecuteCommand()
         {
-            if (CommandName == null)
+            if (string.IsNullOrEmpty(CommandName))
             {
                 Say("I support the following commands:");
 



More information about the Ros-diffs mailing list