Fix of the Week

Here you can discuss ReactOS related topics.

Moderator: Moderator Team

Post Reply
Haos
Test Team
Posts: 2954
Joined: Thu Mar 22, 2007 5:42 am
Contact:

Fix of the Week

Post by Haos » Sat Apr 02, 2011 4:58 pm

2011-04-02:

Award goes to Smiley for: http://www.reactos.org/bugzilla/show_bug.cgi?id=3232 - a bug three years old finally fixed.

gabrielilardi
Moderator Team
Posts: 873
Joined: Sat Sep 02, 2006 1:30 am
Location: Italy

Re: Fix of the Week

Post by gabrielilardi » Wed Apr 13, 2011 1:00 pm

Commit by rharabien :: r51322 reactos/dll/win32/shell32/ (desktop.c shlview.c): (link)
[SHELL32]

Return 1 in WM_ERASEBKGND when desktop is painted
Fix background for desktop icons and their labels
Moreover fixes explorer_new background

Image

gabrielilardi
Moderator Team
Posts: 873
Joined: Sat Sep 02, 2006 1:30 am
Location: Italy

Re: Fix of the Week

Post by gabrielilardi » Wed Apr 13, 2011 4:05 pm

Also:
Commit by gadamopoulos :: r51323 reactos/dll/win32/shell32/shlview.c: (link)
[shell32]

Properly arrange icons in explorer shell view window. This also fixes navigating in files with keyboard arrows

fixing a two years old bug.
Keep it up guys!

gabrielilardi
Moderator Team
Posts: 873
Joined: Sat Sep 02, 2006 1:30 am
Location: Italy

Re: Fix of the Week

Post by gabrielilardi » Fri Apr 15, 2011 8:57 am

Commit by mjmartin :: r51344 reactos/drivers/usb/nt4compat/usbdriver/keyboard.c: (link)
[usbdriver]

KbdDispatch: Set Status vice IoStatus.Status for all branches of switch. Use break instead of goto intcontfailure. The previous code would set Status to what ever was in the IoStatus.Status of the IRP and return that Status. Some times this would be STATUS_PENDING, which IIRC is a no-no. This caused the kbdclass to enter into a wait that would never be satisifed hence blocking the keyboard thread. This should fix the failure of keyboard input bugs.

Fixed bug 4724

gabrielilardi
Moderator Team
Posts: 873
Joined: Sat Sep 02, 2006 1:30 am
Location: Italy

Re: Fix of the Week

Post by gabrielilardi » Fri Apr 15, 2011 11:01 pm

Commit by rharabien :: r51356 reactos/subsystems/win32/win32k/ (include/engobjects.h objects/freetype.c): (link)
[WIN32K]

Revert part of 37148. One FontGDI is used for fonts with different sizes. Do not cache font metrics then and instead calculate them every time when needed. It fixes spacing in menus if some application uses default GUI font with size other than 11. See issue #4106 for more details.

Fixed bugs:
4218:
Image

and 4106:
Image

gabrielilardi
Moderator Team
Posts: 873
Joined: Sat Sep 02, 2006 1:30 am
Location: Italy

Re: Fix of the Week

Post by gabrielilardi » Wed Apr 20, 2011 7:47 pm

Commit by rharabien :: r51409 reactos/drivers/storage/floppy/floppy.c: (link)
[FLOPPY]
Increase floppy drives count in global ConfigurationInformation. Fixes not working floppies in explorer.
See issue #4236 for more details.

Now floppy drives are shown in explorer.

vicmarcal
Test Team
Posts: 2732
Joined: Mon Jul 07, 2008 12:35 pm

Re: Fix of the Week

Post by vicmarcal » Thu Apr 28, 2011 1:54 pm

Commit by Jimtabor: [Win32k] Fix KsStudios actions with Hooks. r51468

I personally love this Fix. Jimtabor Patch:
- UNIMPLEMENTED;
- break;
+ // We do not support anything else here so we should return normal even when sending a hook.
+ return 0;

The results:
Before that revision: User32:MSG 10255 tested.620 failed.
After that revision: User32:MSG 10522(+267)tested.600 (-20)failed.

I have never seen such performance (lineschanged/testsfixed)
Image

Haos
Test Team
Posts: 2954
Joined: Thu Mar 22, 2007 5:42 am
Contact:

Re: Fix of the Week

Post by Haos » Thu Apr 28, 2011 11:20 pm

http://build.reactos.org/changes/8676

Revision 51470

Timo's GDI Handle manager rewrite \o/

encoded
Posts: 35
Joined: Mon Jun 11, 2007 9:39 am

Re: Fix of the Week

Post by encoded » Fri Apr 29, 2011 1:20 am

just 500 commits ago http://reactos.org/testman/compare.php?ids=4851,5590 .... nice weeks ;)

gabrielilardi
Moderator Team
Posts: 873
Joined: Sat Sep 02, 2006 1:30 am
Location: Italy

Re: Fix of the Week

Post by gabrielilardi » Sun May 01, 2011 4:41 pm

Commit by rharabien :: r51526 reactos/dll/win32/shell32/shlview.c: (link)
[SHELL32]

Properly support WM_SYSCOLORCHANGE in ShellView window. Changing system colors in ReactOS works perfectly now :)
(and all the previous commits to make it work)

Commit by gadamopoulos :: r51520 reactos/base/system/winlogon/sas.c: (link)
[winlogon]

Implement restarting the shell in case of a failure. kudos to hpoussin

gabrielilardi
Moderator Team
Posts: 873
Joined: Sat Sep 02, 2006 1:30 am
Location: Italy

Re: Fix of the Week

Post by gabrielilardi » Mon May 02, 2011 10:54 am

Commit by ekohl :: r51529 reactos/ (4 files in 2 dirs): (link)
[EVENTLOG]

Add event sources "EventLog" and "Service Control Manager" to the registry.
Implement an internal event reporting function and report the successful start of the event logging service.

Thanks to the recent work from Eric Kohl on the event service and event viewer, events start getting registered:

Image

gabrielilardi
Moderator Team
Posts: 873
Joined: Sat Sep 02, 2006 1:30 am
Location: Italy

Re: Fix of the Week

Post by gabrielilardi » Wed May 04, 2011 9:14 am

Commit by jimtabor :: r51571 reactos/subsystems/win32/win32k/ntuser/ (input.c msgqueue.c): (link)
[Win32k]

Move up the chain to convert F10 to system key mode before going into the queue, so when in menu tracking, the message can be removed and processed, see bug 1009.

James Tabor is working hard to get keyboard shortcuts working, thanks to his recent work now F10 and Shift-F10 work properly.

Haos
Test Team
Posts: 2954
Joined: Thu Mar 22, 2007 5:42 am
Contact:

Re: Fix of the Week

Post by Haos » Wed May 11, 2011 12:43 am

http://svn.reactos.org/svn/reactos?view ... sion=51667

Sam Arun Raj Seeniraj after considerable amount of work managed to fix a massive issue from late 2005 (bug 993).

gabrielilardi
Moderator Team
Posts: 873
Joined: Sat Sep 02, 2006 1:30 am
Location: Italy

Re: Fix of the Week

Post by gabrielilardi » Tue May 24, 2011 8:58 am

Commit by jimtabor :: r51831 reactos/dll/win32/user32/ (5 files in 4 dirs): (link)
[User32]

Add Switch Class support. See bug 5378. Original patch by David Quintana. Alt-Tab works the same as windows, Alt-Esc needs more work.

Image

gabrielilardi
Moderator Team
Posts: 873
Joined: Sat Sep 02, 2006 1:30 am
Location: Italy

Re: Fix of the Week

Post by gabrielilardi » Mon May 30, 2011 5:23 pm

Commit by jimtabor :: r51973 reactos/ (4 files in 3 dirs): (link)
[ScreenSaver]

Fixed screen saver load and save plus the registry problems.
With this last commit, Jim fixed an old time bug which prevented screensavers to start automatically. Keep it up!

Post Reply

Who is online

Users browsing this forum: Bing [Bot], DotBot [Crawler], Google [Bot] and 2 guests