Question on free look aside list

Ask your support questions in here

Moderator: Moderator Team

Post Reply
brwilson
Posts: 1
Joined: Thu Feb 28, 2008 3:37 am

Question on free look aside list

Post by brwilson » Thu Feb 28, 2008 3:50 am

In reading through some code on the ReactOS I have a question on the ObpFreeCapturedAttributes funtion found in the ntoskrnl\include\internal\ob_x.h file. In this funtion you check to see if it will go past the depth for the P entry. If so you switch to the L entry of the look aside list for that type. If the entry will go past the depth for the L entry it freed with the free method for that type of look aside list. Yet if it does not go past the depth the buffer is never pushed on the look aside list. Should there not be an else condition like:
else
{
/* The free was within the Depth */
InterlockedPushEntrySList(&List->L.ListHead,
(PSINGLE_LIST_ENTRY)Buffer);
}

Or did I miss read the function?

Z98
Release Engineer
Posts: 3379
Joined: Tue May 02, 2006 8:16 pm
Contact:

Post by Z98 » Thu Feb 28, 2008 4:49 am

I'd say you might have found something. There's been a memory bug that's annoying the crap out of one of our testers and this might be related. Hopefully it is. I'll try to get one of the developers to look at what you're referring to.

fireball
Developer
Posts: 358
Joined: Tue Nov 30, 2004 10:40 pm
Location: Moscow, Russia
Contact:

Post by fireball » Thu Feb 28, 2008 1:37 pm

A fix committed in 32521, thanks for information!
Aleksey Bragin,
ReactOS Project Lead

Post Reply

Who is online

Users browsing this forum: No registered users and 0 guests