Fix of the Week

Here you can discuss ReactOS related topics.

Moderator: Moderator Team

gabrielilardi
Moderator Team
Posts: 873
Joined: Sat Sep 02, 2006 1:30 am
Location: Italy

Re: Fix of the Week

Post by gabrielilardi » Tue Jun 14, 2011 9:11 pm

Commit by rharabien :: revision 52234 reactos/boot/freeldr/freeldr/ (6 files in 4 dirs): (link)
[FREELDR]

Return const pointers instead of converting them
Fix MemoryMapSizeInPages calculation
Don't use pages after 4GB limit on x86 (PAE is not supported yet)
Should fix starting ROS on 4GB machines See issue bug 6031 for more details.

Mna.
Posts: 120
Joined: Thu Dec 02, 2010 3:13 pm

Re: Fix of the Week

Post by Mna. » Thu Jun 16, 2011 1:22 pm

Saibamen, please, don't erase this message :)

I would like to thank Rafał Harabień (rafalh) for his patch/Fix r52234. It really solves problem of starting ReactOS on 4Gb of memory! (bug #6031)
Thank you! :)

gabrielilardi
Moderator Team
Posts: 873
Joined: Sat Sep 02, 2006 1:30 am
Location: Italy

Re: Fix of the Week

Post by gabrielilardi » Thu Jun 16, 2011 4:37 pm

Commit by cgutman :: revision 52278 reactos/lib/fslib/vfatlib/vfatlib.c: (link)
[VFATLIB]

Determine the correct FAT type based on the size and offset of the partition if the current type is not a FAT type (another FS type or unformatted)
Formatting a floppy, blank partition, or other non-FAT formatted partition from within ROS no longer fails

gabrielilardi
Moderator Team
Posts: 873
Joined: Sat Sep 02, 2006 1:30 am
Location: Italy

Re: Fix of the Week

Post by gabrielilardi » Sat Jun 18, 2011 3:28 pm

Commit by rharabien :: revision 52332 reactos/subsystems/win32/win32k/ntuser/ (vis.c winpos.c): (link)
[WIN32K]

Don't clip siblings in co_WinPosSetWindowPos when window has no WS_CLIPSIBLINGS style. Fixes ReactOS about box.
Commented out line with WS_CLIPCHILDREN support needs more work
Simplify co_WinPosSetWindowPos a bit

Fixes bug 2769

gabrielilardi
Moderator Team
Posts: 873
Joined: Sat Sep 02, 2006 1:30 am
Location: Italy

Re: Fix of the Week

Post by gabrielilardi » Wed Jun 22, 2011 9:04 am

I had slipped this one:
Commit by cgutman :: revision 52247 reactos/drivers/storage/floppy/ (floppy.c ioctl.c readwrite.c): (link)
[FLOPPY]

Validate the handle type
Fix a bug that broke file system remounting after a media change: bug 5189.

gabrielilardi
Moderator Team
Posts: 873
Joined: Sat Sep 02, 2006 1:30 am
Location: Italy

Re: Fix of the Week

Post by gabrielilardi » Thu Jun 23, 2011 12:23 am

Commit by rharabien :: revision 52343 reactos/ (3 files in 3 dirs): (link)
[WIN32K]

Remove commented out lines added in r52332 - clip children should not be taken into account here [SHELL32]
Use COPYRIGHT_YEAR definition instead of current year.

Fixes bug 3542

Image

Haos
Test Team
Posts: 2954
Joined: Thu Mar 22, 2007 5:42 am
Contact:

Re: Fix of the Week

Post by Haos » Sat Jun 25, 2011 2:42 pm

This is more like commit of the month. It took so many months to get to current stage... first kdcom implementation, then CMake conversion, then whole July dedicated to MSVC fixes, just to reach this stage:
http://img155.imageshack.us/img155/9271 ... ard02i.png

What you see is working WinDBG (with minor glitches), on working kdcom, enabling us to connect to VBOX vm, running MSVC built ReactOS. We can see our own PDB symbols and source level debugging. Concentrated awesomness.

I will not point any specific revision, there's been too many of them. This is a tribute to everyone working hard to make this possible. Naming, in alphabetical order: Amine, Arty, Ged, Giannis, Jerome, Sir_richard, Timo, Usurp, and probably many more i cannot recall at this very moment.

Haos
Test Team
Posts: 2954
Joined: Thu Mar 22, 2007 5:42 am
Contact:

Re: Fix of the Week

Post by Haos » Sun Jul 03, 2011 12:16 pm

http://svn.reactos.org/svn/reactos?view ... sion=52510
"- Retest network related hanging bugs after this please (ftp dir hang is fixed)"

gabrielilardi
Moderator Team
Posts: 873
Joined: Sat Sep 02, 2006 1:30 am
Location: Italy

Re: Fix of the Week

Post by gabrielilardi » Tue Aug 02, 2011 9:39 am

Lately aicom has been working hard fixing bugs in the network stack, especially in afd.

Also:

Commit by rharabien :: revision 53022 reactos/subsystems/win32/win32k/ntuser/hook.c: (link)
[WIN32K]

Fix possible thread reference leak when calling hook
Fix possible memory corruption if hook is unexpectedly removed
Cleanup hooks a bit
Fixes bug 1567 (explorer ghost in taskmgr)

oswetto
Posts: 109
Joined: Mon Oct 26, 2009 10:43 pm

Post by oswetto » Fri Sep 02, 2011 4:29 pm

Author: akhaldi
Mega Romanian translation commit.
Bugs 6422, 6424, 6425, 6426, 6427, 6428, 6429, 6430, 6432, 6438, 6442, 6446, 6450 and 6451.
http://svn.reactos.org/svn/reactos/?vie ... sion=53511

gonzoMD
Posts: 1018
Joined: Fri Oct 20, 2006 7:49 am
Location: Germany
Contact:

Re: Fix of the Week

Post by gonzoMD » Fri Sep 09, 2011 1:21 pm

I would say this is it:
Commit by akhaldi :: r53653 reactos/ (436 files in 15 dirs): (link)

[SHELL32]

Reintegrate the c++ shell32 branch. Exemplary team-work.. kudos !
Better code quality, more tests run with less failures... and more.
Dedicated to everyone who helped ;)

vicmarcal
Test Team
Posts: 2732
Joined: Mon Jul 07, 2008 12:35 pm

Re: Fix of the Week

Post by vicmarcal » Wed Oct 05, 2011 11:26 pm

Code: Select all

Commit by cgutman :: r54016 reactos/ (3 files in 3 dirs): (link)

[HAL]

    Implement support for scatter/gather DMA
    Tested with Intel's NDIS 5.1 PRO/1000 driver (but more testing would be helpful to weed out bugs) [NDIS]
    Report NDIS 5.1 now since S/G DMA is supported
    Stop warning when S/G DMA is used
Now a lot of Ethernet cards and Windows XP drivers may work in ReactOS.
Image

oswetto
Posts: 109
Joined: Mon Oct 26, 2009 10:43 pm

Re: Fix of the Week

Post by oswetto » Thu Oct 06, 2011 3:08 pm


oswetto
Posts: 109
Joined: Mon Oct 26, 2009 10:43 pm

Re: Fix of the Week

Post by oswetto » Thu Oct 06, 2011 4:59 pm

Fix bug
bug 6388

oswetto
Posts: 109
Joined: Mon Oct 26, 2009 10:43 pm

Re: Fix of the Week

Post by oswetto » Fri Oct 07, 2011 10:16 am

Blocker bug: bug 6271
bug 6522
Last edited by vicmarcal on Fri Oct 07, 2011 10:41 am, edited 1 time in total.
Reason: Fixing a tag

Post Reply

Who is online

Users browsing this forum: Ahrefs [Bot], DotBot [Crawler] and 1 guest