Fix of the Week
Moderator: Moderator Team
-
- Moderator Team
- Posts: 873
- Joined: Sat Sep 02, 2006 1:30 am
- Location: Italy
Re: Fix of the Week
Commit by rharabien :: revision 52234 reactos/boot/freeldr/freeldr/ (6 files in 4 dirs): (link)
[FREELDR]
Return const pointers instead of converting them
Fix MemoryMapSizeInPages calculation
Don't use pages after 4GB limit on x86 (PAE is not supported yet)
Should fix starting ROS on 4GB machines See issue bug 6031 for more details.
[FREELDR]
Return const pointers instead of converting them
Fix MemoryMapSizeInPages calculation
Don't use pages after 4GB limit on x86 (PAE is not supported yet)
Should fix starting ROS on 4GB machines See issue bug 6031 for more details.
Re: Fix of the Week
Saibamen, please, don't erase this message
I would like to thank Rafał Harabień (rafalh) for his patch/Fix r52234. It really solves problem of starting ReactOS on 4Gb of memory! (bug #6031)
Thank you!
I would like to thank Rafał Harabień (rafalh) for his patch/Fix r52234. It really solves problem of starting ReactOS on 4Gb of memory! (bug #6031)
Thank you!
-
- Moderator Team
- Posts: 873
- Joined: Sat Sep 02, 2006 1:30 am
- Location: Italy
Re: Fix of the Week
Commit by cgutman :: revision 52278 reactos/lib/fslib/vfatlib/vfatlib.c: (link)
[VFATLIB]
Determine the correct FAT type based on the size and offset of the partition if the current type is not a FAT type (another FS type or unformatted)
Formatting a floppy, blank partition, or other non-FAT formatted partition from within ROS no longer fails
[VFATLIB]
Determine the correct FAT type based on the size and offset of the partition if the current type is not a FAT type (another FS type or unformatted)
Formatting a floppy, blank partition, or other non-FAT formatted partition from within ROS no longer fails
-
- Moderator Team
- Posts: 873
- Joined: Sat Sep 02, 2006 1:30 am
- Location: Italy
Re: Fix of the Week
Commit by rharabien :: revision 52332 reactos/subsystems/win32/win32k/ntuser/ (vis.c winpos.c): (link)
[WIN32K]
Don't clip siblings in co_WinPosSetWindowPos when window has no WS_CLIPSIBLINGS style. Fixes ReactOS about box.
Commented out line with WS_CLIPCHILDREN support needs more work
Simplify co_WinPosSetWindowPos a bit
Fixes bug 2769
[WIN32K]
Don't clip siblings in co_WinPosSetWindowPos when window has no WS_CLIPSIBLINGS style. Fixes ReactOS about box.
Commented out line with WS_CLIPCHILDREN support needs more work
Simplify co_WinPosSetWindowPos a bit
Fixes bug 2769
-
- Moderator Team
- Posts: 873
- Joined: Sat Sep 02, 2006 1:30 am
- Location: Italy
Re: Fix of the Week
I had slipped this one:
Commit by cgutman :: revision 52247 reactos/drivers/storage/floppy/ (floppy.c ioctl.c readwrite.c): (link)
[FLOPPY]
Validate the handle type
Fix a bug that broke file system remounting after a media change: bug 5189.
Commit by cgutman :: revision 52247 reactos/drivers/storage/floppy/ (floppy.c ioctl.c readwrite.c): (link)
[FLOPPY]
Validate the handle type
Fix a bug that broke file system remounting after a media change: bug 5189.
-
- Moderator Team
- Posts: 873
- Joined: Sat Sep 02, 2006 1:30 am
- Location: Italy
Re: Fix of the Week
Commit by rharabien :: revision 52343 reactos/ (3 files in 3 dirs): (link)
[WIN32K]
Remove commented out lines added in r52332 - clip children should not be taken into account here [SHELL32]
Use COPYRIGHT_YEAR definition instead of current year.
Fixes bug 3542
[ external image ]
[WIN32K]
Remove commented out lines added in r52332 - clip children should not be taken into account here [SHELL32]
Use COPYRIGHT_YEAR definition instead of current year.
Fixes bug 3542
[ external image ]
Re: Fix of the Week
This is more like commit of the month. It took so many months to get to current stage... first kdcom implementation, then CMake conversion, then whole July dedicated to MSVC fixes, just to reach this stage:
http://img155.imageshack.us/img155/9271 ... ard02i.png
What you see is working WinDBG (with minor glitches), on working kdcom, enabling us to connect to VBOX vm, running MSVC built ReactOS. We can see our own PDB symbols and source level debugging. Concentrated awesomness.
I will not point any specific revision, there's been too many of them. This is a tribute to everyone working hard to make this possible. Naming, in alphabetical order: Amine, Arty, Ged, Giannis, Jerome, Sir_richard, Timo, Usurp, and probably many more i cannot recall at this very moment.
http://img155.imageshack.us/img155/9271 ... ard02i.png
What you see is working WinDBG (with minor glitches), on working kdcom, enabling us to connect to VBOX vm, running MSVC built ReactOS. We can see our own PDB symbols and source level debugging. Concentrated awesomness.
I will not point any specific revision, there's been too many of them. This is a tribute to everyone working hard to make this possible. Naming, in alphabetical order: Amine, Arty, Ged, Giannis, Jerome, Sir_richard, Timo, Usurp, and probably many more i cannot recall at this very moment.
Re: Fix of the Week
http://svn.reactos.org/svn/reactos?view ... sion=52510
"- Retest network related hanging bugs after this please (ftp dir hang is fixed)"
"- Retest network related hanging bugs after this please (ftp dir hang is fixed)"
-
- Moderator Team
- Posts: 873
- Joined: Sat Sep 02, 2006 1:30 am
- Location: Italy
Re: Fix of the Week
Lately aicom has been working hard fixing bugs in the network stack, especially in afd.
Also:
Commit by rharabien :: revision 53022 reactos/subsystems/win32/win32k/ntuser/hook.c: (link)
[WIN32K]
Fix possible thread reference leak when calling hook
Fix possible memory corruption if hook is unexpectedly removed
Cleanup hooks a bit
Fixes bug 1567 (explorer ghost in taskmgr)
Also:
Commit by rharabien :: revision 53022 reactos/subsystems/win32/win32k/ntuser/hook.c: (link)
[WIN32K]
Fix possible thread reference leak when calling hook
Fix possible memory corruption if hook is unexpectedly removed
Cleanup hooks a bit
Fixes bug 1567 (explorer ghost in taskmgr)
Author: akhaldi
Mega Romanian translation commit.
Bugs 6422, 6424, 6425, 6426, 6427, 6428, 6429, 6430, 6432, 6438, 6442, 6446, 6450 and 6451.
http://svn.reactos.org/svn/reactos/?vie ... sion=53511
Mega Romanian translation commit.
Bugs 6422, 6424, 6425, 6426, 6427, 6428, 6429, 6430, 6432, 6438, 6442, 6446, 6450 and 6451.
http://svn.reactos.org/svn/reactos/?vie ... sion=53511
Re: Fix of the Week
I would say this is it:
Commit by akhaldi :: r53653 reactos/ (436 files in 15 dirs): (link)
[SHELL32]
Reintegrate the c++ shell32 branch. Exemplary team-work.. kudos !
Better code quality, more tests run with less failures... and more.
Dedicated to everyone who helped
Re: Fix of the Week
Code: Select all
Commit by cgutman :: r54016 reactos/ (3 files in 3 dirs): (link)
[HAL]
Implement support for scatter/gather DMA
Tested with Intel's NDIS 5.1 PRO/1000 driver (but more testing would be helpful to weed out bugs) [NDIS]
Report NDIS 5.1 now since S/G DMA is supported
Stop warning when S/G DMA is used
Who is online
Users browsing this forum: EmuandCo, Google [Bot], Majestic-12 [Bot] and 72 guests