mjansen: Welcome!

Here you can discuss ReactOS related topics.

Moderator: Moderator Team

Post Reply
User avatar
Black_Fox
Posts: 1584
Joined: Fri Feb 15, 2008 9:44 pm
Location: Czechia

mjansen: Welcome!

Post by Black_Fox »

Congratz on getting the commit access, Mark :-)

User avatar
Swyter
Posts: 114
Joined: Sun Apr 10, 2011 11:21 am
Location: Spain ← Europe ← Planet Earth ← Milky Way ← Universe

Re: mjansen: Welcome!

Post by Swyter »

Hopefully this won't be the last of a much needed new batch of developers. It's about time!
External patch contributor for ux/user-mode/l10n/winapi. Sometimes I fix a bit of everything everywhere.

learn_more
Developer
Posts: 169
Joined: Fri Dec 19, 2014 10:00 pm

Re: mjansen: Welcome!

Post by learn_more »

Thanks!

hbelusca
Developer
Posts: 1164
Joined: Sat Dec 26, 2009 10:36 pm
Location: Zagreb, Croatia

Re: mjansen: Welcome!

Post by hbelusca »

Congrats \o/

fulea.stefan
Posts: 121
Joined: Sun Aug 14, 2011 3:38 pm
Location: București (Bucharest), România

Re: mjansen: Welcome!

Post by fulea.stefan »

First, congratulation for both you Mark, and ReactOS for new committer. I hope both of you will grow together and learn more along the way.
Second, forgive me for reckoning that the best way to report something with your first commit is here. You left in the resource file more inclusions of localized resources than there really exist:
https://svn.reactos.org/svn/reactos/tru ... sion=71131
It's nothing serious, everything builds fine (or at least on my machine), but it can be a little bit cleaner than this.
Best wishes for your future work!

learn_more
Developer
Posts: 169
Joined: Fri Dec 19, 2014 10:00 pm

Re: mjansen: Welcome!

Post by learn_more »

fulea.stefan wrote:First, congratulation for both you Mark, and ReactOS for new committer. I hope both of you will grow together and learn more along the way.
Second, forgive me for reckoning that the best way to report something with your first commit is here. You left in the resource file more inclusions of localized resources than there really exist:
https://svn.reactos.org/svn/reactos/tru ... sion=71131
It's nothing serious, everything builds fine (or at least on my machine), but it can be a little bit cleaner than this.
Best wishes for your future work!
Thanks!
All those inclusions are disabled because the files are not translated yet, but it would indeed be cleaner had i left em out completely.

ps: Contacting me on the forum is not the best way, I hardly ever read the forum, only when alerted by someone to read a topic ;)
IRC, Jira, email all work faster.

Post Reply

Who is online

Users browsing this forum: dark, Semrush [Bot] and 9 guests