Fix of the Week

Here you can discuss ReactOS related topics.

Moderator: Moderator Team

Post Reply
Maribo63_4
Posts: 74
Joined: Thu Mar 31, 2005 7:43 pm
Location: Neulußheim/Germany
Contact:

Re: Fix of the Week

Post by Maribo63_4 » Mon Sep 09, 2013 11:17 am

OK, i have to say:
I was plain wrong. :)
This API-Call exists in Vista+. It has nothing to do with x64 Architecture of Windows.
http://msdn.microsoft.com/en-us/library ... s.85).aspx

Microsoft implemented it for systems, that run a loooong time without restart. It's the same thing as the "year 2038 Problem". :D
gonzoMD wrote: But if you download a 32 bit installation of FF, why the hell does it expect a 64 bit Function exported?
maybe FF is recognizing ReactOS as NT6.0 not as NT5.2? :?

Z98
Release Engineer
Posts: 3379
Joined: Tue May 02, 2006 8:16 pm
Contact:

Re: Fix of the Week

Post by Z98 » Mon Sep 09, 2013 6:52 pm

How to explain this, GetTickCount64 is not some exclusive 64bit only function. It returns a 64bit value, which 32bit code is perfectly capable of storing and using.

Maribo63_4
Posts: 74
Joined: Thu Mar 31, 2005 7:43 pm
Location: Neulußheim/Germany
Contact:

Re: Fix of the Week

Post by Maribo63_4 » Mon Sep 09, 2013 7:13 pm

Z98 wrote:How to explain this, GetTickCount64 is not some exclusive 64bit only function. It returns a 64bit value, which 32bit code is perfectly capable of storing and using.
That's what I meant ;) I tested it today and realized, that Microsoft did this "to identify bugs that might not occur until the system has been running for a long time" <-- MSDN. So in laymans Terms: "we make a 64bit return value to prevent (arithmetic)overflows".

gonzoMD
Posts: 1008
Joined: Fri Oct 20, 2006 7:49 am
Location: Germany
Contact:

Re: Fix of the Week

Post by gonzoMD » Fri Sep 20, 2013 8:07 am

Thomas Faber wrote:[NTOSKRNL] - Return process pool quota on free - Do not use POOL_QUOTA_FAIL_INSTEAD_OF_RAISE on non-quota allocations - Welcome back, device installation wizard CORE-7459 #resolve
Bye Bye NPFS Regression

EmuandCo
Developer
Posts: 4278
Joined: Sun Nov 28, 2004 7:52 pm
Location: Germany, Bavaria, Steinfeld
Contact:

Re: Fix of the Week

Post by EmuandCo » Fri Sep 20, 2013 8:32 am

Well... regression^^
Lets call it revealed hidden bug.
Image
ReactOS is still in alpha stage, meaning it is not feature-complete and is recommended only for evaluation and testing purposes.

gonzoMD
Posts: 1008
Joined: Fri Oct 20, 2006 7:49 am
Location: Germany
Contact:

Re: Fix of the Week

Post by gonzoMD » Fri Sep 20, 2013 9:08 am

EmuandCo wrote:Well... regression^^
Lets call it revealed hidden bug.
A function that worked before a change, but doesn't after the change is a regression imo.
The revealed hidden bug is the cause of the regression :P Ätschibätsch

but this doesn't matter, devwiz is back and everything is fine

EmuandCo
Developer
Posts: 4278
Joined: Sun Nov 28, 2004 7:52 pm
Location: Germany, Bavaria, Steinfeld
Contact:

Re: Fix of the Week

Post by EmuandCo » Fri Sep 20, 2013 11:01 am

Thats the spirit ^^
Image
ReactOS is still in alpha stage, meaning it is not feature-complete and is recommended only for evaluation and testing purposes.

blumoon94
Posts: 5
Joined: Fri Jan 22, 2010 3:18 am

Re: Fix of the Week

Post by blumoon94 » Fri Oct 18, 2013 9:07 pm

So I was wondering about the DLLs that are swappable. I have been experimenting with them and mixing/matching different ones. Can anybody give me a rundown of what DLLs do what and what they need from each other. And also how they relate to things like winlogon.exe, crss.exe, smss.exe, etc?

Z98
Release Engineer
Posts: 3379
Joined: Tue May 02, 2006 8:16 pm
Contact:

Re: Fix of the Week

Post by Z98 » Fri Oct 18, 2013 9:32 pm

It'd be faster for you to just read MSDN than wait for an answer here.

hbelusca
Developer
Posts: 1119
Joined: Sat Dec 26, 2009 10:36 pm
Location: Zagreb, Croatia

Re: Fix of the Week

Post by hbelusca » Fri Oct 18, 2013 9:46 pm

And it's not the good forum topic you were looking for...

blumoon94
Posts: 5
Joined: Fri Jan 22, 2010 3:18 am

Re: Fix of the Week

Post by blumoon94 » Sat Oct 19, 2013 8:16 pm

Okay. That will work. Just wanted to let everyone know that I was able to get some Windows 7 DLLs to work with ReactOS as well. I don't know if that means much though. Also the Windows 7 userinit.exe works well too.

gonzoMD
Posts: 1008
Joined: Fri Oct 20, 2006 7:49 am
Location: Germany
Contact:

Re: Fix of the Week

Post by gonzoMD » Thu Oct 31, 2013 8:14 pm

Pierre Schweitzer wrote:[NTOSKRNL] - Finally fully implement FstubVerifyPartitionTableEFI(). It is capable of fixing a GPT disk. - Fix implementation of FstubReadHeaderEFI() (which returns a pointer to the header). Fixed all the other functions accordingly. Note that you have to be careful when using Disk->Buffer. You can easily read a buffer that doesn't contain your data anylonger. - Fix implementation of FstubReadPartitionTableEFI(). It was improperly dealing with the backup table. Now, it will look for it and replace/recreate it if not found where expected. - Fix implementation of FstubWriteEntryEFI(). The computation of memory placement was wrong, and thus it was missing partitions and causing corruption. Thank you checksums! In case you format a disk with GPT using Linux (with GParted, for instance), don't be surprised if once started with ReactOS your GPT is modified, and especially its backup table moved. They don't have the same sector counts. It was a nice way to tests whether ReactOS properly write GPT. Which it does now :-).
I think after many weeks w/o FOTW this is a good candidate. (I thought to take the psapi one at first but then I read Partition and I knew that this is the chosen one :p)

BrentNewland
Posts: 175
Joined: Wed Oct 05, 2011 7:32 am

Re: Fix of the Week

Post by BrentNewland » Fri Nov 01, 2013 1:54 am

I think next week's will be fixing the Explorer shell copy bugs. Those have been around for years and result in data loss, so that will be a big improvement.

hbelusca
Developer
Posts: 1119
Joined: Sat Dec 26, 2009 10:36 pm
Location: Zagreb, Croatia

Re: Fix of the Week

Post by hbelusca » Fri Nov 29, 2013 12:44 am

SVN wrote: akhaldi r61117 trunk/reactos/base/applications/cmdutils/ (131 files in 16 dirs) * http://svn.reactos.org/svn/reactos?view ... sion=61117
[CMDUTILS]
* Improve resource files.
CORE-7637
... 22 commits later ....
SVN wrote: akhaldi r61139 trunk/reactos/ntoskrnl/ include/resource.h ntoskrnl.rc * http://svn.reactos.org/svn/reactos?view ... sion=61139
[NTOSKRNL]
* And finally: improve ze kirnel's resource files.
CORE-7637 #resolve
See http://jira.reactos.org/browse/CORE-7637 to understand why Amine did that !

gonzoMD
Posts: 1008
Joined: Fri Oct 20, 2006 7:49 am
Location: Germany
Contact:

Re: Fix of the Week

Post by gonzoMD » Fri Nov 29, 2013 12:48 am

hbelusca wrote:
SVN wrote: akhaldi r61117 trunk/reactos/base/applications/cmdutils/ (131 files in 16 dirs) * http://svn.reactos.org/svn/reactos?view ... sion=61117
[CMDUTILS]
* Improve resource files.
CORE-7637
... 22 commits later ....
SVN wrote: akhaldi r61139 trunk/reactos/ntoskrnl/ include/resource.h ntoskrnl.rc * http://svn.reactos.org/svn/reactos?view ... sion=61139
[NTOSKRNL]
* And finally: improve ze kirnel's resource files.
CORE-7637 #resolve
See http://jira.reactos.org/browse/CORE-7637 to understand why Amine did that !
some hours ago I wanted to post Erics fdd driver commit but this is much more epic. (not the impact but the amount of work)

Post Reply

Who is online

Users browsing this forum: Ahrefs [Bot] and 0 guests