Need help with my first patch

All development related issues welcome

Moderator: Moderator Team

Post Reply
milawynsrealm
Posts: 43
Joined: Wed Jul 20, 2011 10:48 pm

Need help with my first patch

Post by milawynsrealm » Wed Oct 19, 2011 5:12 am

I am attempting to create a patch file that I want to submit and this is my very first time doing so. The patch itself is for Spider Solitaire and affects the message box that you see if you close the program in the middle of the game (http://www.reactos.org/bugzilla/show_bug.cgi?id=6589). I tried to create a patch file on my own, but ended up only creating a 'diff' file instead, which they don't want. What do I do? I've already tested it against the latest SVN source, so I already know the code works.

Saibamen
Posts: 212
Joined: Mon Jul 19, 2010 11:19 am
Location: Poland
Contact:

Re: Need help with my first patch

Post by Saibamen » Wed Oct 19, 2011 7:23 am

If you're at Windows - create patch with TortoiseSVN
ReactOS Forum Global Moderator
IT-Maniak.pl administrator

milawynsrealm
Posts: 43
Joined: Wed Jul 20, 2011 10:48 pm

Re: Need help with my first patch

Post by milawynsrealm » Wed Oct 19, 2011 7:55 am

Yes I am using windows, and yes, I do have TortoiseSVN, but how do I create a patch using it. And just for you information, I have no SVN account.

evilslon
Posts: 261
Joined: Sat Apr 11, 2009 7:39 pm
Location: Russia, Ivanovo
Contact:

Re: Need help with my first patch

Post by evilslon » Wed Oct 19, 2011 10:49 am

milawynsrealm wrote:Yes I am using windows, and yes, I do have TortoiseSVN, but how do I create a patch using it. And just for you information, I have no SVN account.
http://www.reactos.org/wiki/Submitting_Patches

Carlo Bramix
Posts: 282
Joined: Thu Jan 04, 2007 12:43 am
Location: Italy

Re: Need help with my first patch

Post by Carlo Bramix » Wed Oct 19, 2011 12:25 pm

milawynsrealm wrote:I am attempting to create a patch file that I want to submit and this is my very first time doing so.
Actually you may find easier the usage of RosBE for your development with ReactOS.

1) Download latest RosBE from here:
http://www.reactos.org/wiki/Build_Environment

2) Install RosBE

3) Launch RosBE

4) Type:

Code: Select all

ssvn create
and wait that SVN downloads the latest source code of ReactOS.
You must have a working internet connection of course.

5) Do the changes you want on the sources.

6) Type from the root source directory:

Code: Select all

svn diff > mypatch.txt
7) Submit the patch to bugzilla with appropriate description and wait patiently.

That's all.

milawynsrealm
Posts: 43
Joined: Wed Jul 20, 2011 10:48 pm

Re: Need help with my first patch

Post by milawynsrealm » Wed Oct 19, 2011 4:51 pm

4) Type:

Code: Select all
ssvn create


and wait that SVN downloads the latest source code of ReactOS.
You must have a working internet connection of course.
I tried that, but got this error message instead:
svn: REPORT of '/reactos/!svn/vcc/default': Could not read response body: connection was closed by server (http://svn.reactos.org)

milawynsrealm
Posts: 43
Joined: Wed Jul 20, 2011 10:48 pm

Re: Need help with my first patch

Post by milawynsrealm » Wed Oct 19, 2011 5:22 pm

I've now tried svn update, but now I get the following error message:

svn: Repository moved permanently to 'http://svn.reactos.org/reactos'; please relocate

mfldelton
Posts: 16
Joined: Fri Oct 09, 2009 12:06 pm

Re: Need help with my first patch

Post by mfldelton » Fri Oct 21, 2011 1:42 pm

What is the URL that you are checking out currently?

To create a patch,
you will need to go to the root of the trunk and right-click >> TortoiseSVN >> Create patch,
then select the file(s) that you wanna patch.

(note: For indentation, please use 4 spaces instead of a tab for consistent formatting :) )

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest