question on deskmon

[katayama_hirofumi_mz]

source/dll/shellext/deskmon/deskmon.c (16):
[code]static LPTSTR
GetMonitorDevInstID(LPCTSTR lpDeviceID)
{
/* FIXME: Implement, allocate returned string with LocalAlloc! */
return NULL;
}[/code]
What's this?

[vicmarcal]

This is called a Stub
Sometimes an app doesnt lunch because it doesnt find a function, killing the whole app.And maybe this function is not a critical one.
So we prefer to stub the function (as you see the stub doesnt do anything just returning Null),and this can make the app work but of course the function wont perform anything.

[b4dc0d3r]

I looked at this last night, hoping to explain a bit more. I'm assuming this is the same person who fixed bug 5360 and maybe some others, so you might like a bit more technical information.

http://doxygen.reactos.org/d8/dc3/deskm ... cc87f.html

The Doxygen style source code helps make sense of this - I didn't understand it last night but after sleeping on it maybe this helps.

GetMonitorDevInstID() is called by ShowMonitorProperties(), which is called by MonitorDlgProc(). I assume this is the 'monitor properties' part of the control panel - but it might be dead code. MonitorDlgProc is called by IDeskMonitor_AddPages() called by IDeskMonitor_IShellPropSheetExt_AddPages() and referred to in shxiface.c (dll / shellext / deskmon). I don't see where that's called.

The ID returned is supposed to be passed to devmgr.dll!DeviceProperties() function, I assume in the form :
PCI\\VEN_8086\&DEV_2445\&SUBSYS_010E1028\&REV_12\\3\&172E68DD\&0\&FD

This is based on a sample here:
http://support.microsoft.com/kb/815320

The devmgr.dll calls seem to be exported, but not documented.

#reactos-dev IRC channel might be a better place to ask if you haven't found it yet. http://www.reactos.org/en/community_irc.html

[Haos]

Indeed Hirofumi (if i correctly detected your first name^^)

We are all anxious to meet you on irc, as your recent wave of patches was really impressive.