steps for a pull request

All development related issues welcome

Moderator: Moderator Team

Post Reply
zecarlos1957
Posts: 21
Joined: Wed Apr 17, 2019 1:13 am

steps for a pull request

Post by zecarlos1957 »

Okay. Step by step we'll get to the destination.

I've created a branch at https://github.com/zecarlos1957/reactos ... nslactions.
After compiling and testing the desired changes in the virtualbox, i insert into this branch.
But I want to put these changes into discussion and review with others, so I click on "create pull request".
An edit box appears with some fields to fill.
One of them:
JIRA issue: [CORE-XXXX] (https://jira.reactos.org/browse/CORE-XXXX)
There is no name space in this edit box.
Also when creating an issue in the jira there is no place to name.
Here are my problems, because Contributors are asked to use the full name when creating a commit
and I do not see where I should put the name.
Should I create an issue in the jira to create
a pull request on GitHub?

Thank you for your attention

User avatar
Fraizeraust
Posts: 233
Joined: Thu Jan 05, 2017 11:46 am
Location: Italy
Contact:

Re: steps for a pull request

Post by Fraizeraust »

The GitHub web page automatically loads the Pull Request template from there. It's not compulsory to fill the JIRA Issue in the description if you do not have any JIRA tickets related with your PR in question.

To set up your name and E-mail globally for whatever commit you create in the future, apply these two command lines as shown below:

Code: Select all

git config --global user.name "NAME HERE"
git config --global user.email "EMAIL HERE"
If you have commits which are already pushed to the origin, you've got to amend each commit in order to change the author name and E-mail. This post comes with a helpful and descriptive information on how to do this.

Bear in mind you need to use Git SCM (for Windows) or the Git command line package (for Linux) to proceed with the steps above.

zecarlos1957
Posts: 21
Joined: Wed Apr 17, 2019 1:13 am

Re: steps for a pull request

Post by zecarlos1957 »

Ok Fraizeraust.
I installed Git- 2.21.0 and TortoiseGit-2.8.0.0.
but for having many default settings windows that I do not understand, do not use yet. It's going to be my next class.
Thanks for the valuable info. A hug.

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest