Hebrew translation of ReactOS

Discuss translation of both ReactOS and the website here.

Moderators: Moderator Team, Web Team

peterooch
Posts: 25
Joined: Fri Oct 21, 2011 4:01 pm
Location: Be'er Sheva, Israel
Contact:

Re: Hebrew translation of ReactOS

Post by peterooch » Thu Mar 07, 2013 8:44 pm

Ways to mirror layouts:
For menus, right-click menus and first main window.

Code: Select all

SetProcessDefaultLayout(LAYOUT_RTL);
// windows drawing starts here...
Dialogs:

Code: Select all

STYLE ....
EXSTYLE WS_EX_LAYOUTRTL
Reference: http://msdn.microsoft.com/en-us/goglobal/bb688119
Dialogs: http://www.winehq.org/pipermail/wine-cv ... 76615.html
mirroring code concept: https://www.dropbox.com/s/1g6hxjs3vwst1 ... ringcode.c (my first serious programming effort :mrgreen: )

peterooch
Posts: 25
Joined: Fri Oct 21, 2011 4:01 pm
Location: Be'er Sheva, Israel
Contact:

Re: Hebrew translation of ReactOS

Post by peterooch » Tue Mar 12, 2013 3:09 pm

The dialogs, when using external style, did not mirrored in ros, and also were graphic corruptions and bugs (push buttons not clickable, tabs etc..)
The other way also doesn't work.
I remember that both firefox and vlc displayed correctly hebrew, in firefox even the menus!
Image
the programs worked perfectly in windows 2003 english with hebrew mui, in both languages and layouts, and in windows 8.
To report in a new issue or to be added to the existing one (CORE-6910)?

hbelusca
Developer
Posts: 1139
Joined: Sat Dec 26, 2009 10:36 pm
Location: Zagreb, Croatia

Re: Hebrew translation of ReactOS

Post by hbelusca » Tue Mar 12, 2013 5:21 pm

Maybe create a new bug, concerning the mirroring. Otherwise, do you know whether wine has problems with mirroring ? Because we share with them some dlls concerning the UI interface.

peterooch
Posts: 25
Joined: Fri Oct 21, 2011 4:01 pm
Location: Be'er Sheva, Israel
Contact:

Re: Hebrew translation of ReactOS

Post by peterooch » Wed Mar 13, 2013 12:16 pm

Tested in my ubuntu 12.04 hebrew setup,
installed wine 1.4,
and works pretty well,
mirroring worked well, with both ways working correctly,
squares in dialogs fixed by installing tahoma font from microsoft ("winetricks tahoma")
letters showing correctly
bugs:
flipped bitmaps, mainly ros logo,
several graphic glitches, but not serious at all.
right click menus not mirrored.
grayed text flipped.
but in overall, worked much better than in ros.

hbelusca
Developer
Posts: 1139
Joined: Sat Dec 26, 2009 10:36 pm
Location: Zagreb, Croatia

Re: Hebrew translation of ReactOS

Post by hbelusca » Wed Mar 13, 2013 3:38 pm

Ok, so add a report on Jira with all of your remarks, so people doing wine syncs for ReactOS can have a look.

ArmyMan007
Posts: 224
Joined: Sat Apr 04, 2009 11:05 am

Re: Hebrew translation of ReactOS

Post by ArmyMan007 » Thu Jun 13, 2013 10:24 am

I've just checked ROS in Hebrew (0.3.15) and it's a bit twisted. For one the text is left-to-right and everything is written backwards. While the concept is great and it probably took a very long time to work on it, apparently there is still a long way to go.
ReactOS - Open Your Windows to Freedom

erkinalp
Posts: 843
Joined: Sat Dec 20, 2008 5:55 pm

Re: Hebrew translation of ReactOS

Post by erkinalp » Thu Jun 13, 2013 11:23 am

Unfortunately such a solution does not work for Arabic, because some letters in Arabic have conjunction only with the previous one.
-uses Ubuntu+GNOME 3 GNU/Linux
-likes Free (as in freedom) and Open Source Detergents
-favors open source of Windows 10 under GPL2

peterooch
Posts: 25
Joined: Fri Oct 21, 2011 4:01 pm
Location: Be'er Sheva, Israel
Contact:

Re: Hebrew translation of ReactOS

Post by peterooch » Tue Jun 18, 2013 3:01 pm

I think i found a solution, as described in http://jira.reactos.org/browse/CORE-700 ... ment-52863
There is wine code thats deals with this problem (or at least i think so...),
but i don't know how to test it, or how to adapt it without breaking the ros gdi...
It's looks very promising... :mrgreen:

peterooch
Posts: 25
Joined: Fri Oct 21, 2011 4:01 pm
Location: Be'er Sheva, Israel
Contact:

Re: Hebrew translation of ReactOS

Post by peterooch » Fri Sep 20, 2013 12:34 pm

Well i created a nice flow chart, trying to clarify the situation with difference between ReactOS and Wine
Image,
Checked both the Wine Code via their code repo (source.winehq.org) and using Ros's Doxygen,
at the end, wine uses usp10 for this, and ros have the exact (maybe not the same version) of the DLL.
At Ros the function is an internal one, and wine syncing will not fix that(mind that hbelusca),
my proposal is to somehow to integrate the function BiDi_Reorder to the function chain, or to figure out something else that will use usp10 at the back end.
As a side note, the user32 edit control(which used in Notepad) uses usp10 function, which in turn handles Bi-Di correctly. Tested that many times.
I solution has been found, now we need to implement it.

ArmyMan007
Posts: 224
Joined: Sat Apr 04, 2009 11:05 am

Re: Hebrew translation of ReactOS

Post by ArmyMan007 » Sun Sep 29, 2013 1:06 pm

peterooch wrote: As a side note, the user32 edit control(which used in Notepad) uses usp10 function, which in turn handles Bi-Di correctly. Tested that many times.
I solution has been found, now we need to implement it.
How do you think of implementing that component?
ReactOS - Open Your Windows to Freedom

peterooch
Posts: 25
Joined: Fri Oct 21, 2011 4:01 pm
Location: Be'er Sheva, Israel
Contact:

Re: Hebrew translation of ReactOS

Post by peterooch » Tue Oct 22, 2013 6:20 pm

ArmyMan007 wrote: How do you think of implementing that component?
The user32 edit control is already in ReactOS (synched from wine IIRC),
Add the Hebrew keyboard layout, after that open notepad, and you have correct alignment.
I checked that in ros many times.

Post Reply

Who is online

Users browsing this forum: No registered users and 9 guests