recapping because I'm a bit confused.

Discuss translation of both ReactOS and the website here.

Moderators: Moderator Team, Web Team

Post Reply
zecarlos1957
Posts: 21
Joined: Wed Apr 17, 2019 1:13 am

recapping because I'm a bit confused.

Post by zecarlos1957 » Sat May 11, 2019 11:06 pm

recapping because I'm a bit confused.

I created a new branch in GitHub "zecarlos1957 / reactos" forked from "reactos / reactos" with the name "portuguese translactions. I made two new files with the names" pt-PT.h "and" pt-PT.rc "and made changes in the file "muilanguages.h", "en-BR.rc" and "syssetup.rc".
Note that before these operations, I had already tested all the changes, compiling without problems and tested in the virtualbox.
Now, should I continue to make other necessary changes to the translation or should I make a pull request?

Thank you for your help

hbelusca
Developer
Posts: 1127
Joined: Sat Dec 26, 2009 10:36 pm
Location: Zagreb, Croatia

Re: recapping because I'm a bit confused.

Post by hbelusca » Sun May 12, 2019 1:10 am

Hi, Nothing forbids you to create a PR as soon as you have some commits working; you can always mark this PR as "WIP" (work in progress) and add more commits in your branch (they will automatically appear in the PR) until you are satisfied with the results.

zecarlos1957
Posts: 21
Joined: Wed Apr 17, 2019 1:13 am

Re: recapping because I'm a bit confused.

Post by zecarlos1957 » Sun May 12, 2019 1:28 am

OK my friend. Thanks for the tip. I'm still trying to familiarize myself with github

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest