Theme Support!!

Ask your support questions in here

Moderator: Moderator Team

jimtabor
Developer
Posts: 226
Joined: Thu Sep 29, 2005 3:00 pm

Theme Support!!

Post by jimtabor »

Hi,
Part of the Win32k (Msg) rewrite I'm working on requires hooks to be applied for future use. These hooks are for Theming support. Yes support for UxTheme.dll, which is incomplete and from w(h)ine. ATM I've started the basic support without the kernel (Server Side) call backs to help load the instances needed for the user32 message subsystem to swap information and data with UxTheme.

So, I just wanted to ask if all of you want this to be added to ReactOS~~~ So let me know, you all have two days....

Thanks,
James

doomonyou
Posts: 64
Joined: Wed May 06, 2009 5:45 pm

Re: Theme Support!!

Post by doomonyou »

I vote for theme support. Add it.

Cube 8
Posts: 9
Joined: Wed Aug 22, 2007 10:43 pm
Location: Greece
Contact:

Re: Theme Support!!

Post by Cube 8 »

Are you kidding?? Of course I (we) would like to see themes support, just like XP! There have been A LOT of XP themes out there. And they still make more!

User avatar
EmuandCo
Developer
Posts: 4393
Joined: Sun Nov 28, 2004 7:52 pm
Location: Germany, Bavaria, Steinfeld
Contact:

Re: Theme Support!!

Post by EmuandCo »

Yes, please add it. As we already were able to see in the past when we spread the first pics of semi Themed apps, theres a big interest out there for it.
ReactOS is still in alpha stage, meaning it is not feature-complete and is recommended only for evaluation and testing purposes.

gabrielilardi
Moderator Team
Posts: 873
Joined: Sat Sep 02, 2006 1:30 am
Location: Italy

Re: Theme Support!!

Post by gabrielilardi »

James go ahead please! add it!!! ;)

Cube 8
Posts: 9
Joined: Wed Aug 22, 2007 10:43 pm
Location: Greece
Contact:

Re: Theme Support!!

Post by Cube 8 »

Well, jimtabor, as you see, there was no reason doing this question. It was self-evident that people would want theming support.
Moreover, the purpose of ReactOS is to become as more alike as possible to Windows XP/2003!

So... go for it!

User avatar
EmuandCo
Developer
Posts: 4393
Joined: Sun Nov 28, 2004 7:52 pm
Location: Germany, Bavaria, Steinfeld
Contact:

Re: Theme Support!!

Post by EmuandCo »

Only thing we still could need after that is TIF or PNG support in UXTheme for transparency ;-)
ReactOS is still in alpha stage, meaning it is not feature-complete and is recommended only for evaluation and testing purposes.

User avatar
X512
Posts: 54
Joined: Mon Jul 13, 2009 10:07 pm
Location: Russia

Re: Theme Support!!

Post by X512 »

Only thing we still could need after that is TIF or PNG support in UXTheme for transparency ;-)
32 bit BMP support alpha transparency too.

User avatar
EmuandCo
Developer
Posts: 4393
Joined: Sun Nov 28, 2004 7:52 pm
Location: Germany, Bavaria, Steinfeld
Contact:

Re: Theme Support!!

Post by EmuandCo »

And are displayed as Black sections in XP UXTheme afaik. If you cant prove me wrong, plz tell me.

Wheeeeeee. Theming :-D
ReactOS is still in alpha stage, meaning it is not feature-complete and is recommended only for evaluation and testing purposes.

vicmarcal
Test Team
Posts: 2732
Joined: Mon Jul 07, 2008 12:35 pm

Re: Theme Support!!

Post by vicmarcal »

I have heard someone talking about Theme support?
Jim go for it!! :)
+1000000000000000000000
And if you can..ehem..solve our issues in the Alpha channel..ehem..I will send you some Spanish wine.

RideBMX
Posts: 76
Joined: Sat Dec 15, 2007 7:38 pm
Location: New York

Re: Theme Support!!

Post by RideBMX »

Are there any known issues or negative effects from adding this that would otherwise change our decisions?

If no, then I wouldn't mind having it added.

gonzoMD
Posts: 1046
Joined: Fri Oct 20, 2006 7:49 am
Location: Germany
Contact:

Re: Theme Support!!

Post by gonzoMD »

pleeeeeeeeeeeeeeeeease add it as soon as possible, if you get it ready, maybe in 0.3.1.

A long wished feature is coming, yeaaaaaaaaaah

That looks like another design-contest for a new default style. (in less far and more near future of course)

SuperDog
Translation Team
Posts: 124
Joined: Tue Mar 04, 2008 2:52 am

Re: Theme Support!!

Post by SuperDog »

I think jimtabor knew the response before asking the question :)
Theming support is of course a must nowadays, and nicer GUI will help us make a much better impression on the public.

hto
Developer
Posts: 2193
Joined: Sun Oct 01, 2006 3:43 pm

Post by hto »

Better to fix bugs…

Smiley
Developer
Posts: 156
Joined: Fri Nov 10, 2006 3:36 pm

Re: Theme Support!!

Post by Smiley »

jimtabor wrote:Hi,
Part of the Win32k (Msg) rewrite I'm working on requires hooks to be applied for future use. These hooks are for Theming support. Yes support for UxTheme.dll, which is incomplete and from w(h)ine. ATM I've started the basic support without the kernel (Server Side) call backs to help load the instances needed for the user32 message subsystem to swap information and data with UxTheme.

So, I just wanted to ask if all of you want this to be added to ReactOS~~~ So let me know, you all have two days....

Thanks,
James
hi jim,
I have done a bit of research for theme support as well. I guess you have seen this wiki page: http://www.reactos.org/wiki/RegisterUserApiHook
I have also created a test application in which I have copied most of the non-client message handling and tuned it to use uxtheme apis to paint its borders and caption. These changed functions can also be used by RegisterUserApiHook. I'll try to find you trhough irc.

Keep up this work!

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest