Rapps-db pull request not merged

Ask your support questions in here

Moderator: Moderator Team

Post Reply
minecraftchest1
Posts: 41
Joined: Tue May 26, 2020 5:30 pm

Rapps-db pull request not merged

Post by minecraftchest1 »

I created a pull request for the rapps-db, which has not been merged. When I created the pull request, it got noticed about 15 minutes later with a question asked. I responded and it had not gotten any more attention.
Here is the link.
https://github.com/reactos/rapps-db/pull/100
My name is MinecraftChest1.
I am a Windows and Linux user.
I have broken reactos once.
That's my resume.

karlexceed
Posts: 513
Joined: Thu Jan 10, 2013 6:17 pm
Contact:

Re: Rapps-db pull request not merged

Post by karlexceed »

Since I'm too lazy to log into GitHub, I'll make the comment here - your SizeBytes is too small.
OLD VALUE: SizeBytes = 4206592
NEW VALUE: SizeBytes = 3684
I assume that the new version is larger than 3.6 kB...

minecraftchest1
Posts: 41
Joined: Tue May 26, 2020 5:30 pm

Re: Rapps-db pull request not merged

Post by minecraftchest1 »

It downloads the installer now.
My name is MinecraftChest1.
I am a Windows and Linux user.
I have broken reactos once.
That's my resume.

karlexceed
Posts: 513
Joined: Thu Jan 10, 2013 6:17 pm
Contact:

Re: Rapps-db pull request not merged

Post by karlexceed »

Ah, I see now. Ignore my previous comment then!

minecraftchest1
Posts: 41
Joined: Tue May 26, 2020 5:30 pm

Re: Rapps-db pull request not merged

Post by minecraftchest1 »

Follow the thread on the PR.
My name is MinecraftChest1.
I am a Windows and Linux user.
I have broken reactos once.
That's my resume.

Post Reply

Who is online

Users browsing this forum: No registered users and 2 guests