Page 4 of 9

Re: Lautus - ReactOS visual style

Posted: Tue Jan 24, 2012 11:20 am
by vicmarcal
iirc the conclussion is that Lautus is legal :)
And seems to be working really well(I will try in 0.3.14RC today)

Re: Lautus - ReactOS visual style

Posted: Tue Jan 24, 2012 1:46 pm
by Pisarz
Yes, I've recreated it. But this thread is quite outdated (I think it was all explained in the other one about theming in General Discussion).

Re: Lautus - ReactOS visual style

Posted: Tue Jan 31, 2012 2:35 pm
by Love4Boobies
Cool, so why isn't it in trunk/reactos/media/themes then? (Unless you, the author, or anyone else has anything against it...)

Re: Lautus - ReactOS visual style

Posted: Tue Jan 31, 2012 3:35 pm
by gonzoMD
Love4Boobies wrote:Cool, so why isn't it in trunk/reactos/media/themes then? (Unless you, the author, or anyone else has anything against it...)
I think because he didn't create a Bugreport/Patch yet ;)

Re: Lautus - ReactOS visual style

Posted: Wed Feb 01, 2012 1:01 am
by Love4Boobies
A patch that just adds files is useless...

Re: Lautus - ReactOS visual style

Posted: Wed Feb 01, 2012 1:39 am
by Pisarz
I think that Lautus could be integrated soon (I've received a message from Smiley about that some time ago) and there is no need for complaining here, just wait.

Re: Lautus - ReactOS visual style

Posted: Wed Feb 01, 2012 3:49 am
by milon
Love4Boobies wrote:A patch that just adds files is useless...
Actually, that's how new files get added to trunk. Everything is added via patches.

Re: Lautus - ReactOS visual style

Posted: Wed Feb 01, 2012 5:50 am
by FlyingIsFun1217
milon wrote:
Love4Boobies wrote:A patch that just adds files is useless...
Actually, that's how new files get added to trunk. Everything is added via patches.
Or commits.

FlyingIsFun1217

Re: Lautus - ReactOS visual style

Posted: Wed Feb 01, 2012 9:39 am
by gonzoMD
Well but many of the commits are based of patches sent from non-official developers for Example Edijus with his many shell32 patches commited by smiley

Re: Lautus - ReactOS visual style

Posted: Wed Feb 01, 2012 10:04 am
by EmuandCo
A commit IS a patch. The SVN tool sends the local chages to the svn server as patch which is then saved as revision number

Re: Lautus - ReactOS visual style

Posted: Wed Feb 01, 2012 11:09 am
by gonzoMD
well this was a misstake by me. I meant the *.diff files that are posted in bugzilla. :oops:

Re: Lautus - ReactOS visual style

Posted: Wed Feb 01, 2012 6:01 pm
by Love4Boobies
I expect that's what everyone except EmuandCo understood :) Anyway, the purpose of a diff file is to apply changes to files. My point was that someone needs to commit the theme and that's that.

Re: Lautus - ReactOS visual style

Posted: Wed Feb 01, 2012 7:37 pm
by Z98
No, it's not that's that. Until Giannis is convinced that a theme was not derived from Microsoft copyrighten DLLs, we are not committing anything into the repository. At this point, and this late into the release cycle, it is highly unlikely this will happen.

Re: Lautus - ReactOS visual style

Posted: Wed Feb 01, 2012 8:42 pm
by EmuandCo
And we won't add any external binaries into the ISOs too. We add what we can build ourself and as long as there no working legal msstyle skeleton in use, we won't add it, sry.

Love4Boobies: soooo funny -_-

Re: Lautus - ReactOS visual style

Posted: Wed Feb 01, 2012 9:13 pm
by FlyingIsFun1217
Maybe a better question for the developers is whether or not there is actually an interest in putting ANY non-default theme into a release build?

FlyingIsFun1217