Page 1 of 1

Avoid hardcoding Tango icons in ReactOS applications

Posted: Tue Dec 22, 2015 9:30 pm
by manuel
Hi!

I use reactos's regedit clone as windows's regedit replace (on windows 7), but i have a suggestion to this application. I see that regedit (reactos) use folder tango icon to show the keys in the registry. I think that not is good idea use the tango icon as resource to draw the keys, regedit (reactos) should use the windows folder icon directly.
This may enabled use themes and that reactos (and applications) be more compatible with they, because else the reactos's application always will show the tango icons. If the user setup a theme, and this theme can setup your icons I think the applications not draw the icons correctly.
Greetings.
[ external image ]

Re: Reactos's applications don't should use tango icons dire

Posted: Fri Jan 01, 2016 11:56 pm
by Nemerian
I second this.

Re: Reactos's applications don't should use tango icons dire

Posted: Mon Jan 04, 2016 5:11 pm
by manuel
Nemerian wrote:I second this.
thanks :D

Re: Reactos's applications don't should use tango icons dire

Posted: Sun Aug 28, 2016 11:36 am
by dizt3mp3r
I'm not sure I understand, do you want it to use tango icons or not?

Re: Reactos's applications don't should use tango icons dire

Posted: Sun Aug 28, 2016 11:07 pm
by middings
I think Manuel wants ReactOS applets such as RegEdit to use the system's icons. Under ReactOS as it currently is, those are the Tango icons. Under Microsoft's versions of a windows OS, those are various sets of Microsoft's proprietary icons.

Manuel appears to suggest that ReactOS's applets should avoid incorporating Tango icons into their own code. Apparently ReactOS's RegEdit applet uses its own copies of Tango icons. Instead, ReactOS applets should obtain their icons using appropriate system calls whenever possible*. Doing this will cause the applet's icons to automatically conform to the system's native icon set.

The benefit of Manuel's suggestion is that ReactOS applets would have a native look and feel under all versions of a windows OS that they support. Manuel anticipates that someday ReactOS's support for themes will be so robust that users could change the system's icon set to one of their own choice.

* perhaps ReactOS's RegEdit applet was written before ReactOS implemented the appropriate system calls

Re: Reactos's applications don't should use tango icons dire

Posted: Mon Aug 29, 2016 1:33 am
by manuel
I think Manuel wants ReactOS applets such as RegEdit to use the system's icons
The benefit of Manuel's suggestion is that ReactOS applets would have a native look and feel under all versions of a windows OS
exactly, regedit from ReactOS show folder icons but with Tango style, not use Windows icons (from shell32.dll), regedit should draw these icons from shell32.dll too, and shell32.dll contain the tango icons.

Re: Reactos's applications don't should use tango icons dire

Posted: Tue Aug 30, 2016 11:21 pm
by reactosfanboy
I agree with manuel here.
Using the icons from shell32 would give native look & feel and would furthermore rreduce regedits binary size.

Re: Reactos's applications don't should use tango icons dire

Posted: Tue Sep 13, 2016 1:58 pm
by ercanersoy
Tango icons is simple. They looks very good for ReactOS.

Re: Reactos's applications don't should use tango icons dire

Posted: Tue Sep 13, 2016 2:51 pm
by dizt3mp3r
ercanersoy wrote:Tango icons is simple. They looks very good for ReactOS.
Perhaps but that isn't the point.

Re: Reactos's applications don't should use tango icons dire

Posted: Wed Sep 14, 2016 10:04 am
by middings
ercanersoy wrote:Tango icons is simple. They looks very good for ReactOS.
Yes, Tango icons are simple and look very good. Manuel proposes that ReactOS's applications should obtain their icons that the system supports using the usual API calls rather than carrying copies of those icons within the applications themselves. This way, ReactOS's applications would use ReactOS's Tango icons when run in ReactOS and Microsoft's icons when ReactOS's applications are run in a Microsoft Windows environment.

Manuel posted a screen capture of ReactOS's RegEdit running under Microsoft Windows 7. ReactOS's RegEdit uses its own internal copies of common system icons (for example, the folder icon) rather than obtaining them from the system using the usual API calls. Thus, ReactOS's RegEdit looks ok when run under ReactOS but strange when run under other ReactOS-compatible operating systems.

I think that enabling the widespread use of ReactOS components, even in Microsoft Windows environments, is beneficial to the ReactOS Project and to the entire Free and Open Source Software (FOSS) community.

Re: Reactos's applications don't should use tango icons dire

Posted: Wed Sep 14, 2016 3:43 pm
by dizt3mp3r
Someone please change the name of this thread to "Reactos' applications should not hardcode the use of tango icons"

It is driving me nuts! (ubersturmbahngrammarNazi).

Re: Reactos's applications don't should use tango icons dire

Posted: Wed Sep 14, 2016 10:33 pm
by middings
I agree.
Shorter alternatives:

Code: Select all

ReactOS applications: avoid hardcoded Tango icons
Do not hardcode Tango icons in ReactOS applications
Avoid hardcoded Tango icons in ReactOS applications
ReactOS applications must avoid hardcoded Tango icons