Fix of the Week

Here you can discuss ReactOS related topics.

Moderator: Moderator Team

hbelusca
Developer
Posts: 1118
Joined: Sat Dec 26, 2009 10:36 pm
Location: Zagreb, Croatia

Re: Fix of the Week

Post by hbelusca » Thu Nov 29, 2012 12:35 pm

Thanks ! :)

oswetto
Posts: 109
Joined: Mon Oct 26, 2009 10:43 pm

Re: Fix of the Week

Post by oswetto » Fri Dec 07, 2012 2:11 pm

Code: Select all

janderwald committed changeset 57814 to the Core ReactOS project
[NDIS] - Fix several bugs in NdisOpenFile - Introduced in rev 5990 (5/9/2003) 

oswetto
Posts: 109
Joined: Mon Oct 26, 2009 10:43 pm

Re: Fix of the Week

Post by oswetto » Mon Apr 15, 2013 11:41 pm

Hermes Belusca-Maito commit new crss in r58770, bug http://jira.reactos.org/browse/CORE-7002 is fixrd!!!

Code: Select all

Hermes Belusca-Maito added a comment - 2013-04-15 19:34 - edited
Committed in revision r58770. 
Thanks Hermes !!!

oswetto
Posts: 109
Joined: Mon Oct 26, 2009 10:43 pm

Re: Fix of the Week

Post by oswetto » Mon Apr 15, 2013 11:47 pm

Fix very old bug
- http://jira.reactos.org/browse/CORE-122 Created: 2004-01-11 00:03
- http://jira.reactos.org/browse/CORE-2510 Created: 2007-10-13 01:05

Thanks Hermes !!!

hbelusca
Developer
Posts: 1118
Joined: Sat Dec 26, 2009 10:36 pm
Location: Zagreb, Croatia

Re: Fix of the Week

Post by hbelusca » Thu Apr 18, 2013 7:40 pm

@ all : you're welcome :D

Also, don't hesitate to report problems that might be caused by the merge (and compare whether they already existed in revision 58769, the one before the merge).

Swyter
Posts: 114
Joined: Sun Apr 10, 2011 11:21 am
Location: Spain ← Europe ← Planet Earth ← Milky Way ← Universe

Re: Fix of the Week

Post by Swyter » Tue Jun 04, 2013 11:14 am

This one does seem symbolically important:
author ekohl <ekohl@97493ccd-5924-5043-b1f5-66cb403b36ce>
Mon, 3 Jun 2013 20:14:46 +0200 (18:14 +0000)


Enable calls to NetLocalGroupDel and NetUserDel. Now we are able to add and remove groups and users.
http://git.reactos.org/?p=reactos.git;a ... 86783f396e
External patch contributor for ux/user-mode/l10n/winapi. Sometimes I fix a bit of everything everywhere.

Black_Fox
Posts: 1584
Joined: Fri Feb 15, 2008 9:44 pm
Location: Czechia

Re: Fix of the Week

Post by Black_Fox » Thu Jun 06, 2013 9:34 am

r59177: Add tests for FsRtl Tunnel Cache APIs. By Moscow State Technical University students Arseny Ashuha, Marina Volosnikova and Denis Petkevich.
r59178: Add tests for SeQueryInformationToken NTAPI. By Moscow State Technical University students Constantine Belev, Denis Grishin, Egor Sinitsyn.
Fireball's university course seems to bear its first publicly visible fruit! :-)

milon
Posts: 969
Joined: Sat Sep 05, 2009 9:26 pm

Re: Fix of the Week

Post by milon » Thu Jun 06, 2013 4:54 pm

Black_Fox wrote:Fireball's university course seems to bear its first publicly visible fruit! :-)
Awesome! :D

Jedi-to-be
Posts: 694
Joined: Sun Mar 16, 2008 11:26 am
Location: Russia, Stavropol
Contact:

Re: Fix of the Week

Post by Jedi-to-be » Mon Jul 08, 2013 10:32 pm

http://jira.reactos.org/browse/CORE-7081
[RTL8139]
- Add an RTL8139 driver based on documentation on OSDev, our existing drivers, and some prior work by Z98
- It should fully work on emulated and real RTL8139 hardware (I developed against QEMU's RTL8139)
- It's not 100% complete (some reset and halt paths aren't done) but everything I tested worked (ping, dwnl, rapps, Firefox)

janl
Posts: 53
Joined: Thu Dec 16, 2010 10:26 pm

Re: Fix of the Week

Post by janl » Sun Aug 04, 2013 5:22 pm

http://jira.reactos.org/browse/CORE-7373 usbohci: boot process freezes after USB port scan. Progress made by Johannes Anderwald and debock.

ConductiveDielectric
Posts: 32
Joined: Thu Aug 01, 2013 6:39 am

Re: Fix of the Week

Post by ConductiveDielectric » Tue Aug 06, 2013 5:20 am

[KERNEL32]: Fix incorrect bracing which was causing SearchPath failures to enter a weird code path. Fix a debug print.
http://code.reactos.org/changelog/reactos?cs=59642

http://jira.reactos.org/browse/CORE-7380

jonaspm
Posts: 585
Joined: Mon Nov 21, 2011 1:10 am
Location: Mexico
Contact:

Re: Fix of the Week

Post by jonaspm » Tue Aug 06, 2013 5:54 am

ConductiveDielectric wrote:[KERNEL32]: Fix incorrect bracing which was causing SearchPath failures to enter a weird code path. Fix a debug print.
http://code.reactos.org/changelog/reactos?cs=59642

http://jira.reactos.org/browse/CORE-7380
janl wrote:http://jira.reactos.org/browse/CORE-7373 usbohci: boot process freezes after USB port scan. Progress made by Johannes Anderwald and debock.
COOL!!! nice work Ion and Johannes :)!
Image

oswetto
Posts: 109
Joined: Mon Oct 26, 2009 10:43 pm

Re: Fix of the Week

Post by oswetto » Thu Aug 22, 2013 11:34 pm

Hermes Belusca-Maito committed changeset 59793 to the Core ReactOS project

[KERNEL32] Fix usage of the 2nd parameter of NtFlushVirtualMemory, in the FlushViewOfFile file. This fixes the creation of "self-extracted" files from executables (e.g. DeviceTree utility from OSR or some Sysinternals tools). CORE-6572 #comment Partly fixed in revision r59793. Now the objinfo.sys file is created without corruption, but there are problems loading the driver itself... This fixes a bug introduced in revision 775 about 14 years ago! Many thanks to Oláf for having debugged DeviceTree and oriented me to the real problem :D

gonzoMD
Posts: 1007
Joined: Fri Oct 20, 2006 7:49 am
Location: Germany
Contact:

Re: Fix of the Week

Post by gonzoMD » Wed Sep 04, 2013 10:01 am

ion committed changeset 59985 to the Core ReactOS project
This commit, in my opinion, marks an important milestone in ReactOS development. One is now able to boot to desktop, launch applications, download through the application manager, play solitaire, minesweeper, launch Task Manager, etc... by using an unmodified Windows 2003 kernel32.dll binary (and, until our NPFS driver is fixed, the unmodified Windows 2003 NPFS driver). Additionally, one is able to achieve the same by booting with an unmodified Windows 2003 ntdll.dll, including a combination of both. The capability to mix-and-match components such as kernel32 and ntdll, at the heart of the system, will allow to better understand apitest failures (just as Wine has long had the capability to use Windows DLLs instead). With these two building blocks, additional Windows 2003 DLLs can be dropped in/tested, etc, and where failures are seen, a likely component can now be blamed. Furthermore, debugging with public symbols for these DLLs is now possible with WinDBG (in fact, this is how many bugs were fixed in this attempt). Many issues already exist when running with this combination FYI, for example, I was not able to launch any installers (tested Firefox and MIRC). This already demonstrates either missing functionality or ReactOS-specific functionality in components which depend on kernel32. I suspect the next step is infrastructure work to get special patchbot/builders to try and report back winetest results, and for additional DLLs to be "ported"/made to work. On a final note, this mixing and matching has benefits on both ends -- it's now likely that ReactOS' ntdll can run on Server 2003, at least far enough to get to Explorer or Task Manager. Running apitests on Server 2003 with and without reactos DLLs should also easily identify if certain DLLs are directly to blame for certain regressions/failures. </end excited rant> [BASESRV]: Allocate the INI mappings from the right heap.
Well, Who has also the opinion that we can call this baby Fix of the year?

Thank you Alex!!!! Hack on!

fLuXx
Posts: 76
Joined: Sun Oct 25, 2009 11:42 am

Re: Fix of the Week

Post by fLuXx » Wed Sep 04, 2013 11:09 am

OMG! Trully a fix of the year (so far). Thanks Alex!

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest