Fix of the Week

Here you can discuss ReactOS related topics.

Moderator: Moderator Team

Bayode1
Posts: 1
Joined: Tue Jul 31, 2018 10:09 pm
Contact:

Re: Fix of the Week

Post by Bayode1 » Tue Jul 31, 2018 10:11 pm

Thanks you Jedi-to-be for pointing out some especially notable fixes as Fix of the Week. I enjoy learning about them.

amber
Posts: 20
Joined: Fri Apr 19, 2013 7:39 pm

Re: Fix of the Week

Post by amber » Tue Aug 28, 2018 1:02 pm

Mistakes like this will now be less!
Image

https://github.com/reactos/reactos/pull/805 is merged!

middings
Posts: 1007
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: Fix of the Week

Post by middings » Wed Aug 29, 2018 10:50 am

For the week of August 26 through September 1, I consider amber's earlier post to be a nomination of Mark Jansen's commit 191dceb (pull request 805, "Fix manifest activation when loading imported dlls") for Fix of the Week. This should get rid of the buggy behavior shown in the screen capture that amber shared. The commit was applied to the development trunk for the 0.4.11 release. (Sorry, 0.4.10!)

This commit resolves CORE-9219, "can't start Evernote 5.8.3" and these issues:
CORE-5663, "Blender v2.57b fails to run" (a 7 year old bug)
CORE-7771, "BumpTop 2.1.6225 does not see msvcp80.dll" (a 4-1/2 year old bug)
CORE-10444, "Microsoft SQL Server 2005 Express Edition installation failure" (a 3 year old bug)

Wow! Thank you Mark Jansen, testers, and bug hunters.

For the week of August 19 through 25, I nominate commits [https://github.com/reactos/reactos/pull ... 0146143af9]747196c[/url], [https://github.com/reactos/reactos/pull ... 60b911b04b]cf4405b[/url], [https://github.com/reactos/reactos/pull ... 5cdcc99de8]2d5c814[/url], and [https://github.com/reactos/reactos/pull ... afa40d9fb9]81f3be4[/url] by GSOC hero Victor Perevertkin (extravert34) with assistance from ReactOS GSOC mentors, especially Hermes Belusca (hbelusca), and Hackfest 2018 participants. All these commits were part of pull request 743. These commits resolved CORE-13769, "Add boot from BTRFS". Fixes made to Freeldr and ntoskrnl to support ReactOS's use of BTRFS help achieve the goal of full NTFS support.

Watch "ReactOS GSoC 2018: BTRFS boot support final report video" on YouTube to see a demonstration of this new ReactOS feature. Also, read Victor's GSOC blog post "GSoC 2018 - booting from BTRFS works!".

A thousand thanks to Victor Perevertkin and everyone else involved!
Last edited by middings on Wed Dec 12, 2018 10:33 pm, edited 1 time in total.

amber
Posts: 20
Joined: Fri Apr 19, 2013 7:39 pm

Re: Fix of the Week

Post by amber » Tue Dec 25, 2018 7:17 pm

This bug should have been fixed two years ago. This patch was waiting in the wings. Fix of the week in the nomination "very slow fixxx":
https://github.com/reactos/reactos/comm ... b85f14764e

Issue: https://jira.reactos.org/browse/CORE-10553

amber
Posts: 20
Joined: Fri Apr 19, 2013 7:39 pm

Re: Fix of the Week

Post by amber » Wed Jan 09, 2019 8:14 pm

Looking at the commit history, I noticed that quite a lot of work was associated with the implementation of new commands in the debugger: "!irpfind" and "!poolfind". These commits were made from January 1 to January 8 - it fits into the"week" period. Perhaps in the future this will give us more "Fix of the Week" :)

middings
Posts: 1007
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: Fix of the Week

Post by middings » Sat Jan 12, 2019 1:27 am

For the week of December 30 through January 5, I nominate commit 6e4e5a0 by Katayama Hirofumi MZ. This commit made on January 5, 2019 fixed [jira]CORE-15558[jira], "Regression, Abiword 2.6.8, the font listbox should display a specific font only once, but displays each of them many many times instead". This commit fixed a regression caused by a bug that was in ReactOS since revision 75491 (August 5 2017).
Fernando Lamas wrote:It is better to look good than to feel good.

karlexceed
Posts: 454
Joined: Thu Jan 10, 2013 6:17 pm
Contact:

Re: Fix of the Week

Post by karlexceed » Mon Feb 04, 2019 9:12 am

I think this commit by EricKohl is a great candidate for a fix of the week: https://github.com/reactos/reactos/comm ... 0791c598fe
[SNDVOL32] Implement the mute checkbox. The tray dialog is done.
Yes! The tray icon for audio is now fully implemented!

gonzoMD
Posts: 1019
Joined: Fri Oct 20, 2006 7:49 am
Location: Germany
Contact:

Re: Fix of the Week

Post by gonzoMD » Thu Feb 07, 2019 11:38 pm

https://github.com/reactos/reactos/comm ... a8b548edae

That fixed our oldest bug in JIRA. It was 15(!) years old. In words: FIFTEEN.
I know that the Intel NIC driver is also a good candidate but this is something to celebrate imo.

middings
Posts: 1007
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: Fix of the Week

Post by middings » Fri Feb 08, 2019 8:41 pm

Was CORE-187, "Local Dll override support in ReactOS", the oldest bug or the longest awaited improvement? :lol:

gonzoMD
Posts: 1019
Joined: Fri Oct 20, 2006 7:49 am
Location: Germany
Contact:

Re: Fix of the Week

Post by gonzoMD » Fri Feb 08, 2019 8:59 pm

The oldest open bug in Jira

middings
Posts: 1007
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: Fix of the Week

Post by middings » Fri Feb 08, 2019 9:30 pm

I made a little joke because CORE-187's issue type was "Improvement".
Congratulations to learn-more (Mark Jansen) for resolving such an old bug.

Post Reply

Who is online

Users browsing this forum: DotBot [Crawler] and 2 guests