Fix of the Week
Moderator: Moderator Team
Re: Fix of the Week
Thanks !
Re: Fix of the Week
Code: Select all
janderwald committed changeset 57814 to the Core ReactOS project
[NDIS] - Fix several bugs in NdisOpenFile - Introduced in rev 5990 (5/9/2003)
Re: Fix of the Week
Hermes Belusca-Maito commit new crss in r58770, bug http://jira.reactos.org/browse/CORE-7002 is fixrd!!!
Thanks Hermes !!!
Code: Select all
Hermes Belusca-Maito added a comment - 2013-04-15 19:34 - edited
Committed in revision r58770.
Re: Fix of the Week
Fix very old bug
- http://jira.reactos.org/browse/CORE-122 Created: 2004-01-11 00:03
- http://jira.reactos.org/browse/CORE-2510 Created: 2007-10-13 01:05
Thanks Hermes !!!
- http://jira.reactos.org/browse/CORE-122 Created: 2004-01-11 00:03
- http://jira.reactos.org/browse/CORE-2510 Created: 2007-10-13 01:05
Thanks Hermes !!!
Re: Fix of the Week
@ all : you're welcome
Also, don't hesitate to report problems that might be caused by the merge (and compare whether they already existed in revision 58769, the one before the merge).
Also, don't hesitate to report problems that might be caused by the merge (and compare whether they already existed in revision 58769, the one before the merge).
- Swyter
- Posts: 114
- Joined: Sun Apr 10, 2011 11:21 am
- Location: Spain ← Europe ← Planet Earth ← Milky Way ← Universe
Re: Fix of the Week
This one does seem symbolically important:
http://git.reactos.org/?p=reactos.git;a ... 86783f396eauthor ekohl <ekohl@97493ccd-5924-5043-b1f5-66cb403b36ce>
Mon, 3 Jun 2013 20:14:46 +0200 (18:14 +0000)
Enable calls to NetLocalGroupDel and NetUserDel. Now we are able to add and remove groups and users.
External patch contributor for ux/user-mode/l10n/winapi. Sometimes I fix a bit of everything everywhere.
Re: Fix of the Week
Fireball's university course seems to bear its first publicly visible fruit!r59177: Add tests for FsRtl Tunnel Cache APIs. By Moscow State Technical University students Arseny Ashuha, Marina Volosnikova and Denis Petkevich.
r59178: Add tests for SeQueryInformationToken NTAPI. By Moscow State Technical University students Constantine Belev, Denis Grishin, Egor Sinitsyn.
Re: Fix of the Week
Awesome!Black_Fox wrote:Fireball's university course seems to bear its first publicly visible fruit!
-
- Posts: 706
- Joined: Sun Mar 16, 2008 11:26 am
- Location: Russia, Stavropol
- Contact:
Re: Fix of the Week
http://jira.reactos.org/browse/CORE-7081
[RTL8139]
- Add an RTL8139 driver based on documentation on OSDev, our existing drivers, and some prior work by Z98
- It should fully work on emulated and real RTL8139 hardware (I developed against QEMU's RTL8139)
- It's not 100% complete (some reset and halt paths aren't done) but everything I tested worked (ping, dwnl, rapps, Firefox)
Re: Fix of the Week
http://jira.reactos.org/browse/CORE-7373 usbohci: boot process freezes after USB port scan. Progress made by Johannes Anderwald and debock.
-
- Posts: 32
- Joined: Thu Aug 01, 2013 6:39 am
Re: Fix of the Week
[KERNEL32]: Fix incorrect bracing which was causing SearchPath failures to enter a weird code path. Fix a debug print.
http://code.reactos.org/changelog/reactos?cs=59642
http://jira.reactos.org/browse/CORE-7380
http://code.reactos.org/changelog/reactos?cs=59642
http://jira.reactos.org/browse/CORE-7380
Re: Fix of the Week
ConductiveDielectric wrote:[KERNEL32]: Fix incorrect bracing which was causing SearchPath failures to enter a weird code path. Fix a debug print.
http://code.reactos.org/changelog/reactos?cs=59642
http://jira.reactos.org/browse/CORE-7380
COOL!!! nice work Ion and Johannes !janl wrote:http://jira.reactos.org/browse/CORE-7373 usbohci: boot process freezes after USB port scan. Progress made by Johannes Anderwald and debock.
Re: Fix of the Week
Hermes Belusca-Maito committed changeset 59793 to the Core ReactOS project
[KERNEL32] Fix usage of the 2nd parameter of NtFlushVirtualMemory, in the FlushViewOfFile file. This fixes the creation of "self-extracted" files from executables (e.g. DeviceTree utility from OSR or some Sysinternals tools). CORE-6572 #comment Partly fixed in revision r59793. Now the objinfo.sys file is created without corruption, but there are problems loading the driver itself... This fixes a bug introduced in revision 775 about 14 years ago! Many thanks to Oláf for having debugged DeviceTree and oriented me to the real problem
[KERNEL32] Fix usage of the 2nd parameter of NtFlushVirtualMemory, in the FlushViewOfFile file. This fixes the creation of "self-extracted" files from executables (e.g. DeviceTree utility from OSR or some Sysinternals tools). CORE-6572 #comment Partly fixed in revision r59793. Now the objinfo.sys file is created without corruption, but there are problems loading the driver itself... This fixes a bug introduced in revision 775 about 14 years ago! Many thanks to Oláf for having debugged DeviceTree and oriented me to the real problem
Re: Fix of the Week
ion committed changeset 59985 to the Core ReactOS project
Thank you Alex!!!! Hack on!
Well, Who has also the opinion that we can call this baby Fix of the year?This commit, in my opinion, marks an important milestone in ReactOS development. One is now able to boot to desktop, launch applications, download through the application manager, play solitaire, minesweeper, launch Task Manager, etc... by using an unmodified Windows 2003 kernel32.dll binary (and, until our NPFS driver is fixed, the unmodified Windows 2003 NPFS driver). Additionally, one is able to achieve the same by booting with an unmodified Windows 2003 ntdll.dll, including a combination of both. The capability to mix-and-match components such as kernel32 and ntdll, at the heart of the system, will allow to better understand apitest failures (just as Wine has long had the capability to use Windows DLLs instead). With these two building blocks, additional Windows 2003 DLLs can be dropped in/tested, etc, and where failures are seen, a likely component can now be blamed. Furthermore, debugging with public symbols for these DLLs is now possible with WinDBG (in fact, this is how many bugs were fixed in this attempt). Many issues already exist when running with this combination FYI, for example, I was not able to launch any installers (tested Firefox and MIRC). This already demonstrates either missing functionality or ReactOS-specific functionality in components which depend on kernel32. I suspect the next step is infrastructure work to get special patchbot/builders to try and report back winetest results, and for additional DLLs to be "ported"/made to work. On a final note, this mixing and matching has benefits on both ends -- it's now likely that ReactOS' ntdll can run on Server 2003, at least far enough to get to Explorer or Task Manager. Running apitests on Server 2003 with and without reactos DLLs should also easily identify if certain DLLs are directly to blame for certain regressions/failures. </end excited rant> [BASESRV]: Allocate the INI mappings from the right heap.
Thank you Alex!!!! Hack on!
Re: Fix of the Week
OMG! Trully a fix of the year (so far). Thanks Alex!
Who is online
Users browsing this forum: Ahrefs [Bot], Hira Javed and 5 guests