1:1 MSPaint clone - not ? but !

Here you can discuss ReactOS related topics.

Moderator: Moderator Team

gyROS
Posts: 197
Joined: Sun Nov 09, 2008 8:10 pm
Location: Deutschland

Re: 1:1 MSPaint clone - not ? but !

Post by gyROS »

I realized one convenient side effect: Due to the last bug fix the zooming bug in ReactOS disappeared.
Therefore the program is now usable in ReactOS in almost the same way it is in Windows.
[ external image ]

Kario
Posts: 89
Joined: Sun Feb 25, 2007 2:48 am
Location: Slovakia
Contact:

Re: 1:1 MSPaint clone - not ? but !

Post by Kario »

nice, nice, very well :D

The123king
Posts: 242
Joined: Mon Jun 16, 2008 6:51 pm

Re: 1:1 MSPaint clone - not ? but !

Post by The123king »

gyROS wrote:
The123king wrote:Have you uploaded the "fixed" version?

I still see a GDI leak in XP
I did upload it, but there was one GetDC without ReleaseDC left. Vista did not seem to care about this one that a lot, but Win2000 and Wine did. I've updated the ZIP file once again and I strongly hope you won't encounter this bug anymore. (At least in wine I don't.)
Ah, yes, GDI leak is very much fixed. Thank you :)

gyROS
Posts: 197
Joined: Sun Nov 09, 2008 8:10 pm
Location: Deutschland

Re: 1:1 MSPaint clone - not ? but !

Post by gyROS »

And even more good news:
- Both, load and save file function are working in a rather acceptable manner and do not use STDIO functions anymore.
- The canvas size is now updated whenever it makes sense.
- Menu items are dynamically en- and disabled.

User avatar
Black_Fox
Posts: 1584
Joined: Fri Feb 15, 2008 9:44 pm
Location: Czechia

Re: 1:1 MSPaint clone - not ? but !

Post by Black_Fox »

Czech translation:
http://sharegadget.com/835701592

Had to edit enclosed makefile a bit, but it compiles and diacritics work correctly too. I removed a lot of LANGUAGE LANG_*, SUBLANG_* throughout the file, I'm used to ReactOS's sole one on the beginning... why are there those more?

Also one thing annoyed me - dialogs (e.g. "Rotate or mirror") cannot be moved and have some redundant free space under titlebar:
[ external image ]

How does your TODO list look like now, anyway? :)

gyROS
Posts: 197
Joined: Sun Nov 09, 2008 8:10 pm
Location: Deutschland

Re: 1:1 MSPaint clone - not ? but !

Post by gyROS »

In MSDN library I've read that written directly before dialog, menu or accelerator entries the language statement does only affect the one that immediately follows.
Inside the dialog boxes everything was ok so far on every system I tested the program on. But I've problems with the styling flags for the dialog boxes title bar.
I haven't found a configuration that worked well on every system, so far. So I kept the initial one.

The menu however now looks like this. Zooming works fine as well.

[ external image ]

Kario
Posts: 89
Joined: Sun Feb 25, 2007 2:48 am
Location: Slovakia
Contact:

Re: 1:1 MSPaint clone - not ? but !

Post by Kario »

nice, gyros ;-)
are the hardcoded strings and names of default file also in your todo list?
*/ is the package updated? /*
for all: how it look with paint in ros svn tree? when will be?

EDIT: the hardcoded strings are also in ABOUT dialog ;-)
EDIT2: YES, package is updated :-)
EDIT3: small bug was found: the eraser paints with the secondary button :!:
Last edited by Kario on Sun Mar 22, 2009 11:41 am, edited 3 times in total.

Kario
Posts: 89
Joined: Sun Feb 25, 2007 2:48 am
Location: Slovakia
Contact:

Re: 1:1 MSPaint clone - not ? but !

Post by Kario »

Black_Fox wrote: [ external image ]
what's your os at the picture? i don't see any problem on my vista... :o
look:
[ external image ]

The123king
Posts: 242
Joined: Mon Jun 16, 2008 6:51 pm

Re: 1:1 MSPaint clone - not ? but !

Post by The123king »

Kario wrote:
Black_Fox wrote: [ external image ]
what's your os at the picture? i don't see any problem on my vista... :o
look:
[ external image ]
Same thing happened under my XP.

User avatar
Black_Fox
Posts: 1584
Joined: Fri Feb 15, 2008 9:44 pm
Location: Czechia

Re: 1:1 MSPaint clone - not ? but !

Post by Black_Fox »

Yes, XP (SP3) here as well.

gyROS
Posts: 197
Joined: Sun Nov 09, 2008 8:10 pm
Location: Deutschland

Re: 1:1 MSPaint clone - not ? but !

Post by gyROS »

Kario wrote:are the hardcoded strings and names of default file also in your todo list?
*/ is the package updated? /*
for all: how it look with paint in ros svn tree? when will be?
Since the functions dealing with file i/o are working now, I can go on with for example displaying the file name in the title bar and the message box and along with this I can move the strings to a string list resource in the language files.
Ros svn tree: Early April should be possible. Hopefully this will solve the code page bugs.
Kario wrote:EDIT: the hardcoded strings are also in ABOUT dialog ;-)
EDIT2: YES, package is updated :-)
EDIT3: small bug was found: the eraser paints with the secondary button :!:
1. I know.
2. See 1.
3. Isn't that the way it should be? Right mouse button exchanges foreground and background color.
Black_Fox wrote:Czech translation:
http://sharegadget.com/835701592
Thanks a lot. I'll incorporate it during this afternoon.
Kario wrote:what's your os at the picture? i don't see any problem on my vista... :o
I tested it in WinVista, Win2000, Win98, Wine and ReactOS without this space below the title bar. That the title bar itself makes problems however, is well known.

The123king
Posts: 242
Joined: Mon Jun 16, 2008 6:51 pm

Re: 1:1 MSPaint clone - not ? but !

Post by The123king »

gyROS wrote:
Kario wrote:what's your os at the picture? i don't see any problem on my vista... :o
I tested it in WinVista, Win2000, Win98, Wine and ReactOS without this space below the title bar. That the title bar itself makes problems however, is well known.
[ external image ]

[ external image ]

Same thing for a few other menu's too

gyROS
Posts: 197
Joined: Sun Nov 09, 2008 8:10 pm
Location: Deutschland

Re: 1:1 MSPaint clone - not ? but !

Post by gyROS »

With the solitair source code as a reference I eventually fixed the problems concerning the dialog title bar. (At least I hope so!)
Everything should work now. If it does not, do not ask me, why.

EDIT: package updated.

lollebol
Posts: 60
Joined: Tue Mar 17, 2009 6:15 pm
Location: Netherlands

Re: 1:1 MSPaint clone - not ? but !

Post by lollebol »

When closing a painting without saving will show a message in german:
" Mochten Sie die Anderungen speichern? "
I'm not sure if thats ok since the rest of the app is english.

anyway good luck on further dev.

gyROS
Posts: 197
Joined: Sun Nov 09, 2008 8:10 pm
Location: Deutschland

Re: 1:1 MSPaint clone - not ? but !

Post by gyROS »

de: "Möchten Sie die Änderungen speichern?" = en: "Do you want to save the changes?"
I'm planning to internationalize that together with including the name of the file in it and in the main title bar.

Post Reply

Who is online

Users browsing this forum: DotBot [Crawler] and 2 guests