where can I find the comment or some detailed documentary?

Here you can discuss ReactOS related topics.

Moderator: Moderator Team

Post Reply
lostlander
Posts: 1
Joined: Mon Oct 29, 2007 5:06 am

where can I find the comment or some detailed documentary?

Post by lostlander »

I'm reading the source code, but there are no comments for functions and datastructures......

Also, there is no third-party documents analyzing the code....

Anyone here can give me some guidelines? Many thanks.

GreatLord
Developer
Posts: 926
Joined: Tue Nov 30, 2004 10:26 am
Location: Sweden

Post by GreatLord »

Hi
ReactOS using documented strruct in most case, you can found them in msdn, OSR or in some books we are using.

We are lazy to write comment, for each devloper in ReactOS have high skill that can and understand code without comment, if start working in a smaller company, you will found no doc, no comment in the source code.
no UML digram or flow digram. you need be skill to read source code and understand the logic in programing. same thing with ReactOS you need read the source code and be good on anyalysing in the head how it works.

Ged
Developer
Posts: 925
Joined: Thu Sep 29, 2005 3:00 pm
Location: UK

Post by Ged »

I spoke to Fireball about this a few weeks ago, and we agreed that kernel all mode should be commented as per the kernel comment style.
It would also be useful to introduce comments for some usermode stuff too.

Hopefully, we'll be able to start improving the code comments within the coming years.

fennec
Posts: 24
Joined: Mon Nov 29, 2004 9:53 am

Post by fennec »

I my opinion can interest someone i think adding comments would be great. I'm trying to get into code but sometime a little explanation would be welcome.

I've read/used .NET framework source code (that is freely available from MS) and there is a lot of useful comments in it.

oiaohm
Posts: 1322
Joined: Sun Dec 12, 2004 8:40 am

Post by oiaohm »

O boy fennec read licence on that. Yes you are allowed to read it but you are not allowed to work on particular projects after you have as a coder. Even some cases not even just documenting.

You are now currently forbin from working on mono project and pnet both .net replacement engines. You may also be forbin from working on sections here.

Nice of Microsoft any coder that reads it now has limited the project they can work on.

For the time being fennec testing and user documentation only for Reactos. Until someone can give a ruling on what you can and cannot touch. We don't need claims to taint.

First thing before reading any code fennec always read the licence so you work out if you are prepared to pay the price.

That .Net framework source code is not what you call free. It has nice long strings attached.

User avatar
betaluva
Posts: 424
Joined: Tue Dec 14, 2004 1:33 am
Location: Australia
Contact:

Post by betaluva »

how can MS enforce those restricitions? are they going to compensate people for lost earnings? :x

oiaohm
Posts: 1322
Joined: Sun Dec 12, 2004 8:40 am

Post by oiaohm »

http://www.microsoft.com/resources/shar ... cense.mspx

They don't have to compensate. They can just directly sue you for breach of copyright. Or the project for breach of copyright. And it was you free option to read it or not. Once you have read you are stuck.

So basically once we know someone has read it that is code means to submit code to anything covered or relegated to what it contains is forbin. Basically Reactos will have no option. All of win32k development is now off limits fennec until sections can be approved not to be into conflit.

Now before anyone gets the bright idea of not telling Reactos and other project you are working with. If it ever comes out that project risked being sued as well as you. This includes projects like Reactos Wine and .Net replacements. The problem is no matter how hidden you think you can keep it most likely you will fail threw many methods. Doing code with flaws that exist in .net but are not part of the true win32 api and so on. Finger prints to taint.

It does not effect you if you are just producing .net applications.

You should never read code without understanding the license

That license also has other patent risks. It is really a bastard of a license.

etko
Posts: 154
Joined: Thu May 26, 2005 3:43 am
Location: Slovakia
Contact:

Post by etko »

I hate microsoft :)

Haos
Test Team
Posts: 2954
Joined: Thu Mar 22, 2007 5:42 am
Contact:

Post by Haos »

Then why etko do you use their products?:)
Use Linux:))

.aart3k
Posts: 339
Joined: Sat Apr 01, 2006 11:21 am

Post by .aart3k »

But such fennec can write some pseudo-code or documentation about how ms'es .net works and some other fellow can implement it in mono/etc :)

Z98
Release Engineer
Posts: 3379
Joined: Tue May 02, 2006 8:16 pm
Contact:

Post by Z98 »

Not necessarily.

oiaohm
Posts: 1322
Joined: Sun Dec 12, 2004 8:40 am

Post by oiaohm »

.aart3k were is the permission to do that.
"Reference use" means use of the software within your company as a reference, in read only form, for the sole purposes of debugging your products, maintaining your products, or enhancing the interoperability of your products with the software, and specifically excludes the right to distribute the software outside of your company.
No were in that does it allow creating documentation at all. It states clearly how you are allowed to use it and its very limited. You will need local laws to over ride the license. So not really usable to a global project. Note you are not even allowed to build the source code into a binary.

That license is toxic level 10. Fennec is going to pay a huge price for reading it. It done now and cannot be undone.

Post Reply

Who is online

Users browsing this forum: No registered users and 5 guests