Will ReactOS still use some code from WINE? (user mode)

Here you can discuss ReactOS related topics.

Moderator: Moderator Team

Post Reply
User avatar
Fraizeraust
Posts: 233
Joined: Thu Jan 05, 2017 11:46 am
Location: Italy
Contact:

Will ReactOS still use some code from WINE? (user mode)

Post by Fraizeraust »

As you guys know, ReactOS and WINE projects are cooperating together like sharing snippets of code from both sides. At the moment ReactOS borrows some code from WINE for the userland part especially Services and System Libraries (as according to this screenshot, source Wikipedia) but things and decisions on which code are shared may differ.

So my mere question is once ReactOS becomes enough stable, compatible and usable for daily usage activities, will ReactOS still borrow code from WINE for the user mode realm or the ReactOS team will start developing code on its own? This question is mainly asked toward developers.

User avatar
EmuandCo
Developer
Posts: 4393
Joined: Sun Nov 28, 2004 7:52 pm
Location: Germany, Bavaria, Steinfeld
Contact:

Re: Will ReactOS still use some code from WINE? (user mode)

Post by EmuandCo »

If the code is Windows compatible, why remake it? Nothing will change on the status quo. We share/optimize/patch what is possible and rewrite what we have to.
ReactOS is still in alpha stage, meaning it is not feature-complete and is recommended only for evaluation and testing purposes.

jimtabor
Developer
Posts: 226
Joined: Thu Sep 29, 2005 3:00 pm

Re: Will ReactOS still use some code from WINE? (user mode)

Post by jimtabor »

Hum?

Some code is sync/ported to Win32k too. Soon the Scroll Class. It's used everywhere already.

Level Up!!!

theuserbl
Posts: 136
Joined: Wed Mar 23, 2005 3:49 pm

Re: Will ReactOS still use some code from WINE? (user mode)

Post by theuserbl »

Fraizeraust wrote:As you guys know, ReactOS and WINE projects are cooperating together like sharing snippets of code from both sides.
This is wrong!
ReactOS uses some code from WINE, but WINE don't use code from ReactOS.
They have had used ReactOS-code. But the last code they have taken from ReactOS is from 2005
https://github.com/wine-mirror/wine/sea ... &q=ReactOS

From 2005 is the StringTable test suite:
https://github.com/reactos/reactos/blob ... ingtable.c
https://github.com/wine-mirror/wine/blo ... ingtable.c

Also have a look at
viewtopic.php?f=2&t=16469

Greetings
theuserbl
Last edited by theuserbl on Sun Aug 27, 2017 9:38 pm, edited 1 time in total.

PurpleGurl
Posts: 1789
Joined: Fri Aug 07, 2009 5:11 am
Location: USA

Re: Will ReactOS still use some code from WINE? (user mode)

Post by PurpleGurl »

Actually, we do occasionally submit patches to Wine.

theuserbl
Posts: 136
Joined: Wed Mar 23, 2005 3:49 pm

Re: Will ReactOS still use some code from WINE? (user mode)

Post by theuserbl »

PurpleGurl wrote:Actually, we do occasionally submit patches to Wine.
And what is the reason, why it is occasionally?

But I really wonder, that is still happend.
Wouldn't it be better, to have for some sources a unique place, where both sides using it?

Greetings
theuserbl

florian
Posts: 458
Joined: Tue Nov 01, 2005 2:19 am
Location: Germany

Re: Will ReactOS still use some code from WINE? (user mode)

Post by florian »

theuserbl wrote:
PurpleGurl wrote:Actually, we do occasionally submit patches to Wine.
And what is the reason, why it is occasionally?

[...]
Like Konata explained it (viewtopic.php?f=2&t=16598#p127166): "ReactOS devs push fixes to bugs in WINE that affect ReactOS. There's a ton of examples of this in the JIRA comments of various bug reports."

middings
Posts: 1026
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: Will ReactOS still use some code from WINE? (user mode)

Post by middings »

theuserbl wrote:
PurpleGurl wrote:Actually, we do occasionally submit patches to Wine.
And what is the reason, why it is occasionally?
Because bugs attributable to Wine are only found occasionally.
Wouldn't it be better, to have for some sources a unique place, where both sides using it?
No. Pushing changes upstream to the code's original provider/maintainer is considered a 'best practice' by the open source community. This practice keeps the responsibility for the code well-defined. Sometimes the phrase 'shared code' is used yet the relationship between two open source projects is almost always a producer-consumer relationship.
Last edited by middings on Tue Aug 29, 2017 8:45 am, edited 1 time in total.

PurpleGurl
Posts: 1789
Joined: Fri Aug 07, 2009 5:11 am
Location: USA

Re: Will ReactOS still use some code from WINE? (user mode)

Post by PurpleGurl »

theuserbl wrote:And what is the reason, why it is occasionally?

But I really wonder, that is still happend.
Wouldn't it be better, to have for some sources a unique place, where both sides using it?

Greetings
theuserbl
Well, they will only accept what mutually helps both. Well, they only will accept if they believe it helps them, but by the time it gets to that, it obviously helps us. And one advantage of them accepting our patches is that is simplifies Wine-syncs.

I tend to agree with you. It would be nice to have a shared repository for code that benefits both projects. But we have differing goals. We are trying to go for a correct implementation, where they are more concerned about it working. Since Wine was made to sit on top of Linux, they can often take shortcuts that we cannot. Plus there is some change in targets. They will try to run as new as possible while we are currently limited to Windows 2003.

Post Reply

Who is online

Users browsing this forum: Ahrefs [Bot], Google [Bot] and 1 guest