Page 1 of 1

mjansen: Welcome!

Posted: Sat Apr 09, 2016 11:50 pm
by Black_Fox
Congratz on getting the commit access, Mark :-)

Re: mjansen: Welcome!

Posted: Sat Apr 09, 2016 11:56 pm
by Swyter
Hopefully this won't be the last of a much needed new batch of developers. It's about time!

Re: mjansen: Welcome!

Posted: Sun Apr 10, 2016 12:50 am
by learn_more
Thanks!

Re: mjansen: Welcome!

Posted: Sun Apr 10, 2016 12:59 am
by hbelusca
Congrats \o/

Re: mjansen: Welcome!

Posted: Mon Apr 11, 2016 4:52 pm
by fulea.stefan
First, congratulation for both you Mark, and ReactOS for new committer. I hope both of you will grow together and learn more along the way.
Second, forgive me for reckoning that the best way to report something with your first commit is here. You left in the resource file more inclusions of localized resources than there really exist:
https://svn.reactos.org/svn/reactos/tru ... sion=71131
It's nothing serious, everything builds fine (or at least on my machine), but it can be a little bit cleaner than this.
Best wishes for your future work!

Re: mjansen: Welcome!

Posted: Mon Apr 11, 2016 11:01 pm
by learn_more
fulea.stefan wrote:First, congratulation for both you Mark, and ReactOS for new committer. I hope both of you will grow together and learn more along the way.
Second, forgive me for reckoning that the best way to report something with your first commit is here. You left in the resource file more inclusions of localized resources than there really exist:
https://svn.reactos.org/svn/reactos/tru ... sion=71131
It's nothing serious, everything builds fine (or at least on my machine), but it can be a little bit cleaner than this.
Best wishes for your future work!
Thanks!
All those inclusions are disabled because the files are not translated yet, but it would indeed be cleaner had i left em out completely.

ps: Contacting me on the forum is not the best way, I hardly ever read the forum, only when alerted by someone to read a topic ;)
IRC, Jira, email all work faster.