major regression

Here you can discuss ReactOS related topics.

Moderator: Moderator Team

hbelusca
Developer
Posts: 1124
Joined: Sat Dec 26, 2009 10:36 pm
Location: Zagreb, Croatia

Re: major regression

Post by hbelusca » Fri Jan 16, 2015 4:39 pm

So... at which revision this problem starts to happen?

oldman
Posts: 1070
Joined: Sun Dec 20, 2009 1:23 pm

Re: major regression

Post by oldman » Fri Jan 16, 2015 5:29 pm

hbelusca wrote:So... at which revision this problem starts to happen?
This does not answer your question, but according to Jim Tabor, it's Freeloader that's the problem!
jimtabor added a comment - 2015-01-14 21:18 - edited
Before throwing the 27 inch LED out the window......

I upped "svn up -r 65904" the ReactOS test branch. Then going into base/setup/usetup "svn up" there. Then going into win32ss "svn up" there too!
It booted from CD and like before installed on real hardware. Guessing one could go through other directories and do the same and stay out of Free Loader "freeldr" one.

Upped everywhere except freeldr directory, boot cd and installs.
jimtabor added a comment - 2015-01-15 12:03
Need to be careful, upping includes could break the build. Overall it works and is boot-able. Freeldr is the problem, and reading all the changes, it's hard to follow.
The hardware breakage is in Freeldr........
Please keep the Windows classic (9x/2000) look and feel.
The layman's guides to - debugging - bug reporting - compiling - with some complementary scripts.
They may help you with a problem, so do have a look at them.

middings
Posts: 1001
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: major regression

Post by middings » Sat Jan 17, 2015 12:34 am

oldman wrote:...according to Jim Tabor, it's Freeloader that's the problem!
Jim Tabor reported his results in JIRA issue CORE-9032.

Webunny
Posts: 1201
Joined: Sat Apr 28, 2012 1:30 pm

Re: major regression

Post by Webunny » Sat Jan 17, 2015 11:00 am

hbelusca wrote:So... at which revision this problem starts to happen?
Well...doesn't he say it in that JIRA report?

"livecd-65905-dbg.iso . does not boot on a real computer livecd-65905-66036 . and livecd-65904 works "

middings
Posts: 1001
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: major regression

Post by middings » Sun Jan 18, 2015 10:14 am

Good news!
CORE-9032
* jimtabor added a comment - 2015-01-17 16:32
[~hpoussin] Thank you! Good job! Hardware is back!~ 8^D R66048 tested good.
I tried r66048 and I give it the Boots On My Machine seal of approval. I nominate Jim Tabor's r66048 for the Fix of the Week.

oldman
Posts: 1070
Joined: Sun Dec 20, 2009 1:23 pm

Re: major regression

Post by oldman » Sun Jan 18, 2015 11:19 am

middings wrote:Good news!
CORE-9032
* jimtabor added a comment - 2015-01-17 16:32
[~hpoussin] Thank you! Good job! Hardware is back!~ 8^D R66048 tested good.
I tried r66048 and I give it the Boots On My Machine seal of approval. I nominate Jim Tabor's r66048 for the Fix of the Week.
Good news indeed! But, shouldn't 'Fix of the Week' go to H Poussin (see below) and the credit for hunting down the bug to FreeLoader, go to Jim Tabor?
hpoussin committed changeset 66048 to the ReactOS Main Repository project

[FREELDR] PXE: fix backward seeking (broken by r66036)

+3 -3 trunk/reactos/boot/freeldr/freeldr/fs/pxe.c

ChangesetYesterday at 22:48

--------------------------------------------------------------------------------------------

hpoussin committed changeset 66047 to the ReactOS Main Repository project

[FREELDR] Limit disk buffer size to 0xC000 bytes, like before r65905

+1 -1 trunk/reactos/boot/freeldr/freeldr/include/arch/pc/x86common.h

ChangesetYesterday at 22:48
Please keep the Windows classic (9x/2000) look and feel.
The layman's guides to - debugging - bug reporting - compiling - with some complementary scripts.
They may help you with a problem, so do have a look at them.

middings
Posts: 1001
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: major regression

Post by middings » Sun Jan 18, 2015 11:57 am

oldman wrote:Good news indeed! But, shouldn't 'Fix of the Week' go to H Poussin... and the credit for hunting down the bug to FreeLoader, go to Jim Tabor?
Yes, you are correct. You caught that before I noticed my error and could sneak back to edit my earlier post. ;)

My thanks to both hpoussin and Jim Tabor for their work to fix this very annoying bug.

Webunny
Posts: 1201
Joined: Sat Apr 28, 2012 1:30 pm

Re: major regression

Post by Webunny » Mon Jan 19, 2015 7:13 pm

If it's fixed, why does the issue remains on 'unresolved' in JIRA?

oldman
Posts: 1070
Joined: Sun Dec 20, 2009 1:23 pm

Re: major regression

Post by oldman » Mon Jan 19, 2015 7:37 pm

Webunny wrote:If it's fixed, why does the issue remains on 'unresolved' in JIRA?
Stop moaning and be thankful that you can now test again with real hardware. The issue will get closed when someone gets around to doing it.
Please keep the Windows classic (9x/2000) look and feel.
The layman's guides to - debugging - bug reporting - compiling - with some complementary scripts.
They may help you with a problem, so do have a look at them.

Webunny
Posts: 1201
Joined: Sat Apr 28, 2012 1:30 pm

Re: major regression

Post by Webunny » Mon Jan 19, 2015 7:52 pm

oldman wrote:
Webunny wrote:If it's fixed, why does the issue remains on 'unresolved' in JIRA?
Stop moaning and be thankful that you can now test again with real hardware. The issue will get closed when someone gets around to doing it.
Where do you see moaning? I simply observed the fact it is said here it's fixed, yet is still 'unresolved' on the JIRA-bugtracker. It's obvious that this is contradictory, hence my question.

As for being thankful, that goes both ways. In fact, logic would indicate it should foremost come from the other direction. I mean, if some error occurred on their contribution-bar, and they fix it; if I ask a question about it, are you then going to say: "Stop moaning and be glad you can give away your money."? Isn't the normally expectancy that it's the one RECEIVING the money that should be thankful in the first place?

Not that I want to make a point of this, but you brought it up. Just saying.

middings
Posts: 1001
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: major regression

Post by middings » Tue Jan 20, 2015 3:31 am

Webunny wrote:If (CORE-9032 is) fixed, why does the issue remains on 'unresolved' in JIRA?
I've noticed that a delay of a day or two occasionally occurs between the time a supposed fix is entered into the ReactOS source code repository and the time the corresponding JIRA issue is marked 'Fixed'. I suppose there is a reasonable explanation.

Webunny
Posts: 1201
Joined: Sat Apr 28, 2012 1:30 pm

Re: major regression

Post by Webunny » Wed Jan 21, 2015 12:22 am

middings wrote:
Webunny wrote:If (CORE-9032 is) fixed, why does the issue remains on 'unresolved' in JIRA?
I've noticed that a delay of a day or two occasionally occurs between the time a supposed fix is entered into the ReactOS source code repository and the time the corresponding JIRA issue is marked 'Fixed'. I suppose there is a reasonable explanation.
Really? The bugs that I know of got turned into 'resolved' within hours of confirmation. I thought mayhap it wasn't completely fixed yet, or maybe they were waiting on more confirmation(s) that it's fixed, before changing the status. That could be possible too.

I could provide the latter, but I only have time for it this weekend.

Jedi-to-be
Posts: 696
Joined: Sun Mar 16, 2008 11:26 am
Location: Russia, Stavropol
Contact:

Re: major regression

Post by Jedi-to-be » Thu Jan 22, 2015 1:38 am

https://jira.reactos.org/browse/CORE-8899

This issue has pacth that helps, test it!

You could try my liveiso https://yadi.sk/d/Fw7QjIine9cnW

Webunny
Posts: 1201
Joined: Sat Apr 28, 2012 1:30 pm

Re: major regression

Post by Webunny » Sat Jan 24, 2015 11:06 am

middings wrote:
Webunny wrote:If (CORE-9032 is) fixed, why does the issue remains on 'unresolved' in JIRA?
I've noticed that a delay of a day or two occasionally occurs between the time a supposed fix is entered into the ReactOS source code repository and the time the corresponding JIRA issue is marked 'Fixed'. I suppose there is a reasonable explanation.
Well, we're the 24th today, and it still hasn't changed. So, as I suspected, it had nothing to do with a presumed 'normal delay of two days'.

I'll be unwarrantable optimistic and assume it's because they want extra confirmation. That's about the only reasonable explanation left, at this point. Well, I did test it with the latest build just now, and it - indeed - works again. No need to keep open this particular issue indefinitely, thus.

Post Reply

Who is online

Users browsing this forum: Bing [Bot], DotBot [Crawler], Istella [Bot] and 2 guests