Blog: Patching Patches and Testing Tests

Here you can discuss ReactOS related topics.

Moderator: Moderator Team

Post Reply
Z98
Release Engineer
Posts: 3379
Joined: Tue May 02, 2006 8:16 pm
Contact:

Blog: Patching Patches and Testing Tests

Post by Z98 » Tue Nov 25, 2014 12:29 am


justincase
Posts: 434
Joined: Sat Nov 15, 2008 4:13 pm

Re: Blog: Patching Patches and Testing Tests

Post by justincase » Tue Nov 25, 2014 1:34 am

High 5 for working on wine's stuff. Too bad it's such a confusing mess, but I suppose that can (at least partly) be blamed on the fact that they try to target compatibility with multiple windows versions, I have a feeling one windows version at a time is confusing enough. :lol:
I reserve the right to ignore any portion of any post if I deem it not constructive or likely to cause the discussion to degenerate.

Pi_User5
Posts: 752
Joined: Thu May 01, 2014 4:18 am
Location: United States

Re: Blog: Patching Patches and Testing Tests

Post by Pi_User5 » Tue Nov 25, 2014 1:45 am

I tried compiling the newest source code and rosbe freaked out. It could not find the explorer-new folder.
I use ReactOS on real hardware. Will you? My Computers: https://www.reactos.org/wiki/PC_ROS_Rigs Go all the way to the bottom.

Image

gigaherz
Posts: 92
Joined: Sat Jan 21, 2006 9:26 pm

Re: Blog: Patching Patches and Testing Tests

Post by gigaherz » Tue Nov 25, 2014 1:51 am

The folder has been rename, you will want to run configure again and do a full build. you may even need to delete the old build output folder.

EDIT: I forgot to change a file, try again. ;P

Pi_User5
Posts: 752
Joined: Thu May 01, 2014 4:18 am
Location: United States

Re: Blog: Patching Patches and Testing Tests

Post by Pi_User5 » Tue Nov 25, 2014 2:04 am

The folder has been rename, you will want to run configure again and do a full build. you may even need to delete the old build output folder.

EDIT: I forgot to change a file, try again. ;P
Trying it now
I use ReactOS on real hardware. Will you? My Computers: https://www.reactos.org/wiki/PC_ROS_Rigs Go all the way to the bottom.

Image

Pi_User5
Posts: 752
Joined: Thu May 01, 2014 4:18 am
Location: United States

Re: Blog: Patching Patches and Testing Tests

Post by Pi_User5 » Tue Nov 25, 2014 2:10 am

Image
New error
I use ReactOS on real hardware. Will you? My Computers: https://www.reactos.org/wiki/PC_ROS_Rigs Go all the way to the bottom.

Image

gigaherz
Posts: 92
Joined: Sat Jan 21, 2006 9:26 pm

Re: Blog: Patching Patches and Testing Tests

Post by gigaherz » Tue Nov 25, 2014 2:34 am

You always have to cd host-tools\ and do "ninja" there before trying to build reactos\

Pi_User5
Posts: 752
Joined: Thu May 01, 2014 4:18 am
Location: United States

Re: Blog: Patching Patches and Testing Tests

Post by Pi_User5 » Tue Nov 25, 2014 2:53 am

You always have to cd host-tools\ and do "ninja" there before trying to build reactos\
I was making one long command that would configure, ninja and build and I guess I left out the ninja part.
I use ReactOS on real hardware. Will you? My Computers: https://www.reactos.org/wiki/PC_ROS_Rigs Go all the way to the bottom.

Image

Oddjob64
Posts: 40
Joined: Sun Jun 01, 2014 10:21 am

Re: Blog: Patching Patches and Testing Tests

Post by Oddjob64 » Tue Nov 25, 2014 12:24 pm

Doesn't the WINE Project still reject contributions made by ReactOS developers?

Black_Fox
Posts: 1584
Joined: Fri Feb 15, 2008 9:44 pm
Location: Czechia

Re: Blog: Patching Patches and Testing Tests

Post by Black_Fox » Tue Nov 25, 2014 2:04 pm

It's not that simple "if fromROS() then reject();" for some time now. From what I know WINE could accept the patch happilly, but you have to keep the coding standard and to prove your fix's correctness by a test.

hbelusca
Developer
Posts: 1133
Joined: Sat Dec 26, 2009 10:36 pm
Location: Zagreb, Croatia

Re: Blog: Patching Patches and Testing Tests

Post by hbelusca » Tue Nov 25, 2014 2:05 pm

Black_Fox wrote:It's not that simple "if fromROS() then reject();" for some time now. From what I know WINE could accept the patch happilly, but you have to keep the coding standard and to prove your fix's correctness by a test.
Yes.

Post Reply

Who is online

Users browsing this forum: Ahrefs [Bot] and 1 guest