Enable drop shadows on desktop?

Here you can discuss ReactOS related topics.

Moderator: Moderator Team

Post Reply
Swyter
Posts: 114
Joined: Sun Apr 10, 2011 11:21 am
Location: Spain ← Europe ← Planet Earth ← Milky Way ← Universe

Enable drop shadows on desktop?

Post by Swyter » Sun Feb 26, 2012 11:11 pm

Something like a week ago I saw that the drop shadow support (for desktop icons) has been added to the trunk.
In the commit message says that has been enabled. But you can't see them on any recent build.

Is there any problem? Requires hardware acceleration? or even better: There's another way to get them by default?.
I've tried a registry hack but the option is flagged as true already, as seen in the changelog.

http://svn.reactos.org/svn/reactos/?vie ... sion=55583
[COMCTL32]
- Add support for LVS_EX_TRANSPARENTSHADOWTEXT style
[SHELL32]
- Add drop shadows support for desktop
- Set proper label color based on background color when drop shadows is disabled
- Update desktop colors when WM_SYSCOLORCHANGE or WM_SETTINGCHANGE msg is received
[BOOTDATA]
- Enable drop shadows by default (this option was hardcoded to 1 before)
[DESK]
- Send WM_SETTINGCHANGE with wParam = 0 when applying changes
[EXPLORER]
- Broadcast WM_SETTINGCHANGE message to shell view window
http://svn.reactos.org/svn/reactos/?vie ... sion=55578
[COMCTL32]
- Add DrawShadowText implementation

Thanks! :)
External patch contributor for ux/user-mode/l10n/winapi. Sometimes I fix a bit of everything everywhere.

preston
Developer
Posts: 272
Joined: Wed Sep 27, 2006 8:19 pm
Location: Prague, Czech Republic

Re: Enable drop shadows on desktop?

Post by preston » Mon Feb 27, 2012 12:37 am

you need to set a wallpaper otherwise it's turned off afaik.

Swyter
Posts: 114
Joined: Sun Apr 10, 2011 11:21 am
Location: Spain ← Europe ← Planet Earth ← Milky Way ← Universe

Re: Enable drop shadows on desktop?

Post by Swyter » Mon Feb 27, 2012 2:38 pm

preston wrote:you need to set a wallpaper otherwise it's turned off afaik.
Negative, I've tried with and without wallpaper, using explorer and explorer_new (maybe it was only enabled on the newer shell), and all that with and without themes service running. :(

It doesn't works for me and my Virtualbox machine using the today's bootcd-55878-dbg revision.


---

Maybe sightly off-topic, but please, may a kind dev give functionality to the explorer's menu bar navigation arrows?
You know, Back and Forth, and upper dir.

Seems like a very basic functionality. Easy to do. With great repercussions until the new shell is done.
External patch contributor for ux/user-mode/l10n/winapi. Sometimes I fix a bit of everything everywhere.

vicmarcal
Test Team
Posts: 2732
Joined: Mon Jul 07, 2008 12:35 pm

Re: Enable drop shadows on desktop?

Post by vicmarcal » Mon Feb 27, 2012 2:47 pm

Did it work for you before?Maybe it is a regression..
Is it enabled by default?
Image

Swyter
Posts: 114
Joined: Sun Apr 10, 2011 11:21 am
Location: Spain ← Europe ← Planet Earth ← Milky Way ← Universe

Re: Enable drop shadows on desktop?

Post by Swyter » Mon Feb 27, 2012 2:53 pm

vicmarcal wrote:Did it work for you before?Maybe it is a regression..
Is it enabled by default?
Never worked for me.
As you can see in the commit log up there, is enabled and the correct value imported into the registry every time is installed.

I like to use bright wallpapers and drop shadows are useful for readability.
Apart of giving it a modern look.
External patch contributor for ux/user-mode/l10n/winapi. Sometimes I fix a bit of everything everywhere.

preston
Developer
Posts: 272
Joined: Wed Sep 27, 2006 8:19 pm
Location: Prague, Czech Republic

Re: Enable drop shadows on desktop?

Post by preston » Mon Feb 27, 2012 5:33 pm


Swyter
Posts: 114
Joined: Sun Apr 10, 2011 11:21 am
Location: Spain ← Europe ← Planet Earth ← Milky Way ← Universe

Re: Enable drop shadows on desktop?

Post by Swyter » Tue Feb 28, 2012 1:22 am

preston wrote:it just works for me http://img69.imageshack.us/img69/8669/dropshadow.jpg
Image

Cool one. You're right, is just that the support is a bit buggy right now.
For example it doesn't works when specifying the wallpaper from an external program (like MSPaint or Firefox built-in functs.)

I suppose that (understandably) the API hasn't been updated yet.

Oh, and the Desktop Properties' Apply button as of bootcd-55890-dbg is a bit buggy and only gets enabled when changing the background color.
Doesn't detects changes in the wallpaper listbox. That minor detail confused me in first place. But looks like it works properly by simply choosing Accept instead.

Minor user feedback glitch. ;) *nudge nudge hint hint*

Pretty good job in general, following your daily progress through RSS. Keep it up!
External patch contributor for ux/user-mode/l10n/winapi. Sometimes I fix a bit of everything everywhere.

Post Reply

Who is online

Users browsing this forum: Ahrefs [Bot], Google [Bot] and 1 guest