I think fork Media Player Classic as ReactOS Media Player is a good choice

Here you can discuss ReactOS related topics.

Moderator: Moderator Team


PurpleGurl
Posts: 1751
Joined: Fri Aug 07, 2009 5:11 am
Location: USA

Re: I think fork Media Player Classic as ReactOS Media Player is a good choice

Post by PurpleGurl » Fri Dec 07, 2018 7:19 am

cernodile wrote:
Thu Dec 06, 2018 9:07 am
As mentioned by elhoir - JIRA is not the place for such discussions. If you'd like to propose it in one go, I suggest going the mailing list way or keep discussing this topic until a developer either takes interest in it or gives a final word on it.
I don't understand why the feature request was closed. It was not posted there as a discussion at all from what I could see. Oh well, just part of why I don't take a more active part here.

cernodile
Posts: 57
Joined: Wed Nov 01, 2017 7:01 pm
Location: Estonia
Contact:

Re: I think fork Media Player Classic as ReactOS Media Player is a good choice

Post by cernodile » Fri Dec 07, 2018 9:14 am

PurpleGurl wrote:
Fri Dec 07, 2018 7:19 am
cernodile wrote:
Thu Dec 06, 2018 9:07 am
As mentioned by elhoir - JIRA is not the place for such discussions. If you'd like to propose it in one go, I suggest going the mailing list way or keep discussing this topic until a developer either takes interest in it or gives a final word on it.
I don't understand why the feature request was closed. It was not posted there as a discussion at all from what I could see. Oh well, just part of why I don't take a more active part here.
JIRA's purpose is to be a bug tracker, rather than idea proposal. I believe only set in stone tasks can go there.
My working rigs:
Dell Latitude E5430 on 0.4.9-vgal - i5-3340M, 8GB (4 utilized) DDR3-1600MHz RAM, booting off a USB.
Image

binarymaster
Posts: 214
Joined: Sun Nov 16, 2014 7:05 pm
Location: Russia, Moscow
Contact:

Re: I think fork Media Player Classic as ReactOS Media Player is a good choice

Post by binarymaster » Fri Dec 07, 2018 9:53 am

dizt3mp3r wrote:
Thu Dec 06, 2018 3:49 pm
Thankyou hbelusca, email sent.
I don't see your mail on ros-dev. :roll:


hbelusca
Developer
Posts: 1109
Joined: Sat Dec 26, 2009 10:36 pm
Location: Zagreb, Croatia

Re: I think fork Media Player Classic as ReactOS Media Player is a good choice

Post by hbelusca » Fri Dec 07, 2018 2:10 pm

@dizt3mp3r: you subscribed by going there first? : https://reactos.org/mailman/listinfo/ros-dev

Patchworks
Posts: 10
Joined: Sat Jul 14, 2018 10:33 am

Re: I think fork Media Player Classic as ReactOS Media Player is a good choice

Post by Patchworks » Thu Dec 20, 2018 3:55 pm

njlyf2011 wrote:
Tue Dec 04, 2018 12:01 pm
So I think fork Media Player Classic as ReactOS Media Player is a good choice.
...but MPC needs directshow codecs (that are NOT efficient for the system performances).

There are *ways* better choices, IMHO:

binarymaster
Posts: 214
Joined: Sun Nov 16, 2014 7:05 pm
Location: Russia, Moscow
Contact:

Re: I think fork Media Player Classic as ReactOS Media Player is a good choice

Post by binarymaster » Thu Dec 20, 2018 4:23 pm

I think for ReactOS its enough to have two built-in players: mplay32.exe which uses MCI API, and amovie.ocx thingy which uses DirectShow API and runs within rundll32 context.

Other more advanced third-party players can be installed from external sources.
Last edited by binarymaster on Sun Dec 30, 2018 7:20 pm, edited 2 times in total.

dizt3mp3r
Posts: 1401
Joined: Mon Jun 14, 2010 5:54 pm

Re: I think fork Media Player Classic as ReactOS Media Player is a good choice

Post by dizt3mp3r » Sun Dec 23, 2018 6:07 pm

hbelusca wrote:
Fri Dec 07, 2018 2:10 pm
@dizt3mp3r: you subscribed by going there first? : https://reactos.org/mailman/listinfo/ros-dev
Thankyou Hbelusca, I eventually managed to sign in and submitted the request. A bit delayed by Christmas preparations.

Smiley
Developer
Posts: 156
Joined: Fri Nov 10, 2006 3:36 pm

Re: I think fork Media Player Classic as ReactOS Media Player is a good choice

Post by Smiley » Sun Dec 30, 2018 8:00 pm

Hey, I responded to your email but by mistake I didn't send it to the list but just to you. I'm writing it here so others can also see what I was saying.

The thing is, Media Player Classic is good, nice and lightweight but uses MFC which is enought to make it impossible to include in ReactOS. It is perfectly fine to have it in Rapps but without also having an open source implementation of MFC we can't compile it ourselves.

reactosfanboy
Posts: 6
Joined: Sun Feb 01, 2015 1:54 pm

Re: I think fork Media Player Classic as ReactOS Media Player is a good choice

Post by reactosfanboy » Sun Dec 30, 2018 8:52 pm

binarymaster wrote:
Thu Dec 20, 2018 4:23 pm
I think for ReactOS its enough to have two built-in players: mplay32.exe which uses MCI API, and amovie.ocx thingy which uses DirectShow API and runs within rundll32 context.

Other more advanced third-party players can be installed from external sources.
I 100% agree to binarymaster's position.

elhoir
Test Team
Posts: 397
Joined: Thu Sep 13, 2007 7:01 pm
Location: Madrid, Spain
Contact:

Re: I think fork Media Player Classic as ReactOS Media Player is a good choice

Post by elhoir » Wed Jan 02, 2019 7:31 pm

+1 for binarymaster's position

Adcock
Posts: 229
Joined: Thu Jul 07, 2016 5:37 pm

Re: I think fork Media Player Classic as ReactOS Media Player is a good choice

Post by Adcock » Wed Jan 02, 2019 8:38 pm

^^^+1

dizt3mp3r
Posts: 1401
Joined: Mon Jun 14, 2010 5:54 pm

Re: I think fork Media Player Classic as ReactOS Media Player is a good choice

Post by dizt3mp3r » Wed Jan 02, 2019 9:47 pm

Received an answer from Giannis Adamopoulos:
Giannis Adamopoulos
Hi,
after having a look at the code of Media Player Classic I saw that it uses MFC. I hope that you can understand that we cannot include any project in ReactOS that uses MFC as we don't have an implementation of it right now nor there exists an open source implementation of it. At some point we may implement the active X controls and things like that but for now they are not a priority.
MFC is a library that ReactOS just does not yet have so this request will have to remain on the back-burner for the moment.

I found something that believes it is an open source alternative to MFC but I'll bet my boots it is not fully compatible.

https://sourceforge.net/projects/win32-framework/
Win32++ is a C++ library used to build windows applications. It is a simple, open source alternative to MFC. Win32++ supports the C++ compilers from GNU and Microsoft. It is an ideal starting point for anyone learning to program for windows, but also caters for the needs of professional developers.

middings
Posts: 990
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: I think fork Media Player Classic as ReactOS Media Player is a good choice

Post by middings » Thu Jan 03, 2019 1:34 pm

Code from other projects is never "free". When such code is added to ReactOS, it adds its own maintenance burden to the ReactOS project. Even keeping RAPPS free of bad download links is now a large maintenance burden.

Post Reply

Who is online

Users browsing this forum: Istella [Bot] and 3 guests