[ros-dev] [ros-diffs] [reactos] 06/12: [EXT2] Correctly zero memory before using it

Pierre Schweitzer pierre at reactos.org
Mon Apr 1 17:15:53 UTC 2019


This is 3rd party code. Can you surround it with #ifdef __REACTOS__?

Le 01/04/2019 à 17:08, Hervé Poussineau a écrit :
> https://git.reactos.org/?p=reactos.git;a=commitdiff;h=76910c358f7197a6b8e283ea267faf7b5c1812ff
> 
> commit 76910c358f7197a6b8e283ea267faf7b5c1812ff
> Author:     Hervé Poussineau <hpoussin at reactos.org>
> AuthorDate: Sat Mar 30 23:06:27 2019 +0100
> Commit:     Hervé Poussineau <hpoussin at reactos.org>
> CommitDate: Mon Apr 1 11:38:32 2019 +0200
> 
>     [EXT2] Correctly zero memory before using it
> ---
>  drivers/filesystems/ext2/src/memory.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/filesystems/ext2/src/memory.c b/drivers/filesystems/ext2/src/memory.c
> index 8915dfeccb..cf569f40cd 100644
> --- a/drivers/filesystems/ext2/src/memory.c
> +++ b/drivers/filesystems/ext2/src/memory.c
> @@ -2072,9 +2072,9 @@ Ext2ParseRegistryVolumeParams(
>  
>      USHORT i, j, k;
>  
> -    RtlZeroMemory(Codepage, CODEPAGE_MAXLEN);
> -    RtlZeroMemory(Prefix, HIDINGPAT_LEN);
> -    RtlZeroMemory(Suffix, HIDINGPAT_LEN);
> +    RtlZeroMemory(Codepage, sizeof(WCHAR) * CODEPAGE_MAXLEN);
> +    RtlZeroMemory(Prefix, sizeof(WCHAR) * HIDINGPAT_LEN);
> +    RtlZeroMemory(Suffix, sizeof(WCHAR) * HIDINGPAT_LEN);
>      RtlZeroMemory(MountPoint, sizeof(USHORT) * 4);
>      RtlZeroMemory(DrvLetter, sizeof(CHAR) * 4);
>  
> 


-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://reactos.org/pipermail/ros-dev/attachments/20190401/6eb43885/attachment.sig>


More information about the Ros-dev mailing list