[ros-dev] [ros-diffs] 01/04: [REACTOS] RtlAssert(): use "%lu" as LineNumber format.

[Hermès BÉLUSCA-MAÏTO]

Yes ! Because for host-tools, on linux, %lu means unsigned long which may NOT be always == 32 bits.

> -----Message d'origine-----
> De : Ros-dev [mailto:ros-dev-bounces at reactos.org] De la part de Michael
> Fritscher
> Envoyé : jeudi 9 août 2018 05:14
> À : ros-dev at reactos.org; Serge Gautherie; ros-diffs at reactos.org
> Objet : Re: [ros-dev] [ros-diffs] 01/04: [REACTOS] RtlAssert(): use "%lu" as
> LineNumber format.
> 
> Moin,
> 
> On 08.08.2018 22:05, Serge Gautherie wrote:
> >
> https://git.reactos.org/?p=reactos.git;a=commitdiff;h=97d3b3ce3349fa87d01ee
> 29d0d08ff2ca8618a7d
> >
> > commit 97d3b3ce3349fa87d01ee29d0d08ff2ca8618a7d
> > Author:     Serge Gautherie <reactos-git_serge_171003 at gautherie.fr>
> > AuthorDate: Thu Jun 21 05:05:50 2018 +0200
> > Commit:     Hermès Bélusca-Maïto <hermes.belusca-maito at reactos.org>
> > CommitDate: Wed Aug 8 21:24:07 2018 +0200
> >
> >     [REACTOS] RtlAssert(): use "%lu" as LineNumber format.
> > ---
> ...
> > -   if (NULL != Message)
> > -   {
> > -      DbgPrint("Assertion \'%s\' failed at %s line %d: %s\n",
> > -               (PCHAR)FailedAssertion,
> > -               (PCHAR)FileName,
> > -               LineNumber,
> > -               Message);
> > -   }
> > -   else
> > -   {
> > -      DbgPrint("Assertion \'%s\' failed at %s line %d\n",
> > -               (PCHAR)FailedAssertion,
> > -               (PCHAR)FileName,
> > -               LineNumber);
> > -   }
> > -
> > -   //DbgBreakPoint();
> > +    if (Message != NULL)
> > +    {
> > +        DbgPrint("Assertion \'%s\' failed at %s line %u: %s\n",
> > +                 (PCHAR)FailedAssertion,
> > +                 (PCHAR)FileName,
> > +                 LineNumber,
> > +                 Message);
> > +    }
> > +    else
> > +    {
> > +        DbgPrint("Assertion \'%s\' failed at %s line %u\n",
> > +                 (PCHAR)FailedAssertion,
> > +                 (PCHAR)FileName,
> > +                 LineNumber);
> > +    }
> > +
> > +    //DbgBreakPoint();
> >  }
> >
> >  // DECLSPEC_NORETURN
> >
> 
> here no %lu, but only %u?
> 
> Best regards,
> Michael Fritscher
> 
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev