[ros-dev] [ros-diffs] [hbelusca] 75008: [USETUP]: Introduce SetupDeleteFile() and SetupMoveFile() (in addition to the already-existing SetupCopyFile()) in order to implement moving / renaming existing files. Will be use...

[Thomas Faber]

On 2017-06-12 01:58, hbelusca at svn.reactos.org wrote:
> +NTSTATUS
> +SetupMoveFile(
> +    IN PCWSTR ExistingFileName,
> +    IN PCWSTR NewFileName,
> +    IN ULONG Flags)
> +{
> +    NTSTATUS Status;
> +    IO_STATUS_BLOCK IoStatusBlock;
> +    OBJECT_ATTRIBUTES ObjectAttributes;
> +    PFILE_RENAME_INFORMATION RenameInfo;
> +    UNICODE_STRING NewPathU, ExistingPathU;
> +    HANDLE SourceHandle = NULL;

This variable fulfills the requirements for _SEH2_VOLATILE

> +    BOOLEAN ReplaceIfExists;
> +
> +    RtlInitUnicodeString(&ExistingPathU, ExistingFileName);
> +    RtlInitUnicodeString(&NewPathU, NewFileName);
> +
> +    _SEH2_TRY
> +    {

Which part of this code needs SEH? That looks like it's purely hiding
bugs.