[ros-dev] [ros-diffs] [jimtabor] 73532: [NtUser] - Fix menu surfing while using MS Office 2003. See CORE-12085 and CORE-12071.

[Thomas Faber]

On 2017-01-13 05:06, jimtabor at svn.reactos.org wrote:
>  VOID FASTCALL
>  IntSendChildNCPaint(PWND pWnd)
>  {
> +   PWND Child;
> +   HWND *List, *phWnd;
> +
> +   List = IntWinListChildren(UserGetDesktopWindow());
> +   if ( List )
> +   {
> +      for (phWnd = List; *phWnd; ++phWnd)
> +      {
> +          Child = ValidateHwndNoErr(*phWnd);
> +          if ( Child && Child->hrgnUpdate == NULL && Child->state & WNDS_SENDNCPAINT)
> +          {
> +             USER_REFERENCE_ENTRY Ref;
> +             UserRefObjectCo(Child, &Ref);
> +             IntSendNCPaint(Child, HRGN_WINDOW);
> +             UserDerefObjectCo(Child);
> +          }
> +      }
> +   }


You leak List here, both in the normal case and in the
exception-during-callout case.