[ros-dev] Merging our x86 HALs

[Hermès BÉLUSCA-MAÏTO]

That's why I'm extremely in favour of keeping the HAL x86 Standard PC mono-processor separate from the other hals (I mean, as a separate dll).
But if you find inside some code that can be shared with the ACPI/APIC/whatever other hal, then just share it! (maybe use some #ifdefs inside as long as it doesn't imply recopying twice the file contents into the ifdef blocks).

Regards

> -----Message d'origine-----
> De : Ros-dev [mailto:ros-dev-bounces at reactos.org] De la part de Michael
> Fritscher
> Envoyé : mercredi 13 décembre 2017 23:06
> À : ros-dev at reactos.org
> Objet : Re: [ros-dev] Merging our x86 HALs
> 
> Hi,
> 
> I think that at least merging most of the versions shouldn't be a big problem.
> We could go Win8's way. Is there a rough estimation, how much is the
> distribution of common code, code for new HW only and code für old HW only?
> 
> To be honest, I don't think that much space will be wasted in the installation or
> during runtime if we merge all (generic) hals to one.
> 
> If I understand it correctly, even on modern HW we need most of the "old"
> ways for initialization. The biggest waste should be the ACPI infrastructure on
> very(!) old HW. And this is how many KB on RAM? 200KB?
> 
> Btw, ACPI went into the mass market ca. 1998. On these days, 32 MB RAM
> were normal. ReactOS wouldn't even boot on these machines.
> 
> Best regards,
> Michael Fritscher
> 
> 
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev