[ros-dev] [ros-diffs] [hbelusca] 72922: [KD] - When enabling or disabling the kernel debugger and setting the KdDebuggerEnabled flag, also update the corresponding user-mode flag in SharedUserData->KdDebuggerEnabled. - ...

[Pierre Schweitzer]

Le 06/10/2016 à 21:01, hbelusca at svn.reactos.org a écrit :
> Author: hbelusca
> Date: Thu Oct  6 19:01:33 2016
> New Revision: 72922
> 
> URL: http://svn.reactos.org/svn/reactos?rev=72922&view=rev
> Log:
> [KD]
> - When enabling or disabling the kernel debugger and setting the KdDebuggerEnabled flag, also update the corresponding user-mode flag in SharedUserData->KdDebuggerEnabled.
> - Turn KdpGetMemorySizeInMBs into a INIT_FUNCTION.
> - Print kernel command line & ARC paths even in debug log file mode.
> 
> [KD64]
> WinKD: Also print our nice ReactOS debug header (version, # of processors & memory MB, kernel command line and ARC paths).
> 
> Modified:
>     trunk/reactos/ntoskrnl/kd/kdinit.c
>     trunk/reactos/ntoskrnl/kd/kdio.c
>     trunk/reactos/ntoskrnl/kd/kdmain.c
>     trunk/reactos/ntoskrnl/kd64/kdapi.c
>     trunk/reactos/ntoskrnl/kd64/kdinit.c
> 
> Modified: trunk/reactos/ntoskrnl/kd/kdio.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kd/kdio.c?rev=72922&r1=72921&r2=72922&view=diff
> ==============================================================================
> --- trunk/reactos/ntoskrnl/kd/kdio.c	[iso-8859-1] (original)
> +++ trunk/reactos/ntoskrnl/kd/kdio.c	[iso-8859-1] Thu Oct  6 19:01:33 2016
> @@ -240,10 +243,15 @@
>          KeInitializeSpinLock(&KdpDebugLogSpinLock);
>  
>          /* Display separator + ReactOS version at start of the debug log */
> -        DPRINT1("---------------------------------------------------------------\n");
> +        DPRINT1("-----------------------------------------------------\n");

This specific change has likely broken any testbot running sysreg2 and
vmware or vbox.
Why was this change even needed?


-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3960 bytes
Desc: Signature cryptographique S/MIME
URL: <http://www.reactos.org/pipermail/ros-dev/attachments/20161006/c946757f/attachment.bin>