[ros-dev] [ros-diffs] [hbelusca] 71524: [SHELL32] - Minor stylistic whitespace changes. - Use 'IDA_DESKBROWSER' instead of hardcoding its value. - The shell progman window uses the COLOR_DESKTOP as its hbrBackground: pa...

[Thomas Faber]

On 2016-06-05 01:29, hbelusca at svn.reactos.org wrote:
> -    rcDesk.left = GetSystemMetrics(SM_XVIRTUALSCREEN);
> -    rcDesk.top = GetSystemMetrics(SM_YVIRTUALSCREEN);
> -    rcDesk.right = rcDesk.left + GetSystemMetrics(SM_CXVIRTUALSCREEN);
> -    rcDesk.bottom = rcDesk.top + GetSystemMetrics(SM_CYVIRTUALSCREEN);
> +    rcDesk.left   = GetSystemMetrics(SM_XVIRTUALSCREEN);
> +    rcDesk.top    = GetSystemMetrics(SM_YVIRTUALSCREEN);
> +    rcDesk.right  = GetSystemMetrics(SM_CXVIRTUALSCREEN);
> +    rcDesk.bottom = GetSystemMetrics(SM_CYVIRTUALSCREEN);

Are you sure about this? "CX" normally means width, so right = left + cx
seems more logical. And SM_XVIRUTALSCREEN is probably 0 most of the
time so it would be hard to notice.