[ros-dev] [ros-diffs] [hbelusca] 71819: [RTL]: Follow what I guess might be Alex' coding standards.

[Timo Kreuzer]

According to the "official" ReactOS coding standards, the previous code 
was perfectly fine.
Code like "If (Value == 0) Value = FOO;" (in one line) does not match 
our coding style rules. (And it's also annoying, when stepping through 
it with WinDbg.)
3 line comments also don't match our coding style :-P

For reference: https://reactos.org/wiki/Coding_Style

Timo


Am 05.07.2016 um 16:30 schrieb Alex Ionescu:
> Coding Style - ReactOS Wiki 
> <https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=2&ved=0ahUKEwiBgrjOxNzNAhVU5WMKHRGND7MQFggjMAE&url=https%3A%2F%2Freactos.org%2Fwiki%2FCoding_Style&usg=AFQjCNHwtNOsUOmSfCB838_p9eIDqT1NQg&sig2=U1hpYA1fc7LH8EGiGxoM7Q&bvm=bv.126130881,d.cGc>
>
> Stop calling them "mine".
>
> Best regards,
> Alex Ionescu
>
> On Mon, Jul 4, 2016 at 5:38 PM, <hbelusca at svn.reactos.org 
> <mailto:hbelusca at svn.reactos.org>> wrote:
>
>     Author: hbelusca
>     Date: Tue Jul  5 00:38:28 2016
>     New Revision: 71819
>
>     URL: http://svn.reactos.org/svn/reactos?rev=71819&view=rev
>     Log:
>     [RTL]: Follow what I guess might be Alex' coding standards.
>
>     Modified:
>         trunk/reactos/sdk/lib/rtl/process.c
>
>     Modified: trunk/reactos/sdk/lib/rtl/process.c
>     URL:
>     http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/rtl/process.c?rev=71819&r1=71818&r2=71819&view=diff
>     ==============================================================================
>     --- trunk/reactos/sdk/lib/rtl/process.c [iso-8859-1] (original)
>     +++ trunk/reactos/sdk/lib/rtl/process.c [iso-8859-1] Tue Jul  5
>     00:38:28 2016
>     @@ -75,7 +75,7 @@
>          PVOID BaseAddress = NULL;
>          SIZE_T EnviroSize;
>          SIZE_T Size;
>     -    PWCHAR Environment = 0;
>     +    PWCHAR Environment = NULL;
>          DPRINT("RtlpInitEnvironment(ProcessHandle: %p, Peb: %p
>     Params: %p)\n",
>                  ProcessHandle, Peb, ProcessParameters);
>
>     @@ -301,7 +301,9 @@
>     DUPLICATE_SAME_ACCESS |
>     DUPLICATE_SAME_ATTRIBUTES);
>                  if (!NT_SUCCESS(Status))
>     +            {
>                      _SEH2_LEAVE;
>     +            }
>              }
>
>              if (ProcessParameters->StandardOutput)
>     @@ -315,7 +317,9 @@
>     DUPLICATE_SAME_ACCESS |
>     DUPLICATE_SAME_ATTRIBUTES);
>                  if (!NT_SUCCESS(Status))
>     +            {
>                      _SEH2_LEAVE;
>     +            }
>              }
>
>              if (ProcessParameters->StandardError)
>     @@ -329,7 +333,9 @@
>     DUPLICATE_SAME_ACCESS |
>     DUPLICATE_SAME_ATTRIBUTES);
>                  if (!NT_SUCCESS(Status))
>     +            {
>                      _SEH2_LEAVE;
>     +            }
>              }
>          }
>          _SEH2_FINALLY
>
>
>
>
>
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.reactos.org/pipermail/ros-dev/attachments/20160708/5707a858/attachment.html>