[ros-dev] [ros-diffs] [gadamopoulos] 72398: [SHELL32] - Fail to delete any file if one is invalid. - Patch by andy-123 CORE-9959

[Thomas Faber]

On 2016-08-20 11:43, gadamopoulos at svn.reactos.org wrote:
> --- trunk/reactos/dll/win32/shell32/shlfileop.cpp	[iso-8859-1] (original)
> +++ trunk/reactos/dll/win32/shell32/shlfileop.cpp	[iso-8859-1] Sat Aug 20 09:43:09 2016
> @@ -1480,6 +1480,19 @@
>              return 0;
>          }
>  
> +    /* Check files. Do not delete one if one file does not exists */
> +    for (i = 0; i < flFrom->dwNumFiles; i++)
> +    {
> +        fileEntry = &flFrom->feFiles[i];
> +
> +        if ((HANDLE)fileEntry->attributes == INVALID_HANDLE_VALUE)

What's wrong with INVALID_FILE_ATTRIBUTES?


> +        {
> +            // This is a windows 2003 server specific value which has been removed.
> +            // Later versions of windows return ERROR_FILE_NOT_FOUND.
> +            return ERROR_SHELL_INTERNAL_FILE_NOT_FOUND;
> +        }
> +    }
> +
>      for (i = 0; i < flFrom->dwNumFiles; i++)
>      {
>          bPathExists = TRUE;