[ros-dev] [ros-diffs] [gedmurphy] 72178: [FLTLIB] - Stub out fltlib.dll. - Add basic implementations for FilterLoad and FilterUnload - Remove the wine code, this lib talks directly to fltmgr.sys and is therefore a react...

[Ged Murphy]

> You're leaking this allocation.
Oops.... Code is still very unfinished so would've picked it up later.

> +// Hack - our SDK reports NTDDI_VERSION as 0x05020100 (from 
> +_WIN32_WINNT 0x502) // which doesn't pass the FLT_MGR_BASELINE check 
> +in fltkernel.h #define NTDDI_VERSION NTDDI_WS03SP1

> We typically set this kind of thing in CMakeLists.txt.. however maybe we should define it this way by default

It's a temporary hack, it definitely doesn't wanna be in cmakelists.txt
We need to come up with a better solution, bumping the version is one possibility.