[ros-dev] [ros-diffs] [cwittich] 68305: [BROWSEUI] don't exposesome interfaces expose IID_IContextMenu3 from CBandSiteMenu

[Christoph von Wittich]

Please revert it then

----- Ursprüngliche Nachricht -----
Von: "Pierre Schweitzer" <pierre at reactos.org>
Gesendet: ‎29.‎06.‎2015 21:36
An: "ros-dev at reactos.org" <ros-dev at reactos.org>; "Christoph von Wittich" <christoph at apiviewer.de>
Betreff: Re: [ros-dev] [ros-diffs] [cwittich] 68305: [BROWSEUI] don't exposesome interfaces expose IID_IContextMenu3 from CBandSiteMenu

This commit regressed (badly) explorer:
https://www3.heisspiter.net/explorer.png

On 28/06/2015 20:22, cwittich at svn.reactos.org wrote:
> Author: cwittich
> Date: Sun Jun 28 18:22:02 2015
> New Revision: 68305
> 
> URL: http://svn.reactos.org/svn/reactos?rev=68305&view=rev
> Log:
> [BROWSEUI]
> don't expose some interfaces
> expose IID_IContextMenu3 from CBandSiteMenu
> 
> Modified:
>     trunk/reactos/dll/win32/browseui/addressband.h
>     trunk/reactos/dll/win32/browseui/addresseditbox.h
>     trunk/reactos/dll/win32/browseui/bandsitemenu.h
>     trunk/reactos/dll/win32/browseui/internettoolbar.h
> 
> Modified: trunk/reactos/dll/win32/browseui/addressband.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/addressband.h?rev=68305&r1=68304&r2=68305&view=diff
> ==============================================================================
> --- trunk/reactos/dll/win32/browseui/addressband.h	[iso-8859-1] (original)
> +++ trunk/reactos/dll/win32/browseui/addressband.h	[iso-8859-1] Sun Jun 28 18:22:02 2015
> @@ -136,6 +136,5 @@
>          COM_INTERFACE_ENTRY_IID(IID_IInputObjectSite, IInputObjectSite)
>          COM_INTERFACE_ENTRY_IID(IID_IPersist, IPersist)
>          COM_INTERFACE_ENTRY_IID(IID_IPersistStream, IPersistStream)
> -        COM_INTERFACE_ENTRY_IID(IID_IDispatch, IDispatch)
>      END_COM_MAP()
>  };
> 
> Modified: trunk/reactos/dll/win32/browseui/addresseditbox.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/addresseditbox.h?rev=68305&r1=68304&r2=68305&view=diff
> ==============================================================================
> --- trunk/reactos/dll/win32/browseui/addresseditbox.h	[iso-8859-1] (original)
> +++ trunk/reactos/dll/win32/browseui/addresseditbox.h	[iso-8859-1] Sun Jun 28 18:22:02 2015
> @@ -97,7 +97,6 @@
>          COM_INTERFACE_ENTRY_IID(IID_IWinEventHandler, IWinEventHandler)
>          COM_INTERFACE_ENTRY_IID(IID_IOleCommandTarget, IOleCommandTarget)
>          COM_INTERFACE_ENTRY_IID(IID_IDispatch, IDispatch)
> -        COM_INTERFACE_ENTRY_IID(IID_IPersist, IPersist)
>          COM_INTERFACE_ENTRY_IID(IID_IPersistStream, IPersistStream)
>      END_COM_MAP()
>  };
> 
> Modified: trunk/reactos/dll/win32/browseui/bandsitemenu.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/bandsitemenu.h?rev=68305&r1=68304&r2=68305&view=diff
> ==============================================================================
> --- trunk/reactos/dll/win32/browseui/bandsitemenu.h	[iso-8859-1] (original)
> +++ trunk/reactos/dll/win32/browseui/bandsitemenu.h	[iso-8859-1] Sun Jun 28 18:22:02 2015
> @@ -55,6 +55,7 @@
>      BEGIN_COM_MAP(CBandSiteMenu)
>          COM_INTERFACE_ENTRY_IID(IID_IShellService, IShellService)
>          COM_INTERFACE_ENTRY_IID(IID_IContextMenu2, IContextMenu2)
> +        COM_INTERFACE_ENTRY_IID(IID_IContextMenu3, IContextMenu3)
>          COM_INTERFACE_ENTRY_IID(IID_IContextMenu, IContextMenu)
>      END_COM_MAP()
>  };
> 
> Modified: trunk/reactos/dll/win32/browseui/internettoolbar.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/internettoolbar.h?rev=68305&r1=68304&r2=68305&view=diff
> ==============================================================================
> --- trunk/reactos/dll/win32/browseui/internettoolbar.h	[iso-8859-1] (original)
> +++ trunk/reactos/dll/win32/browseui/internettoolbar.h	[iso-8859-1] Sun Jun 28 18:22:02 2015
> @@ -228,7 +228,6 @@
>          COM_INTERFACE_ENTRY_IID(IID_IInputObject, IInputObject)
>          COM_INTERFACE_ENTRY_IID(IID_IOleWindow, IOleWindow)
>          COM_INTERFACE_ENTRY_IID(IID_IDockingWindow, IDockingWindow)
> -        COM_INTERFACE_ENTRY_IID(IID_IPersist, IPersist)
>  //        COM_INTERFACE_ENTRY_IID(IID_IPersistStream, IPersistStream)
>          COM_INTERFACE_ENTRY_IID(IID_IPersistStreamInit, IPersistStreamInit)
>          COM_INTERFACE_ENTRY_IID(IID_IOleCommandTarget, IOleCommandTarget)
> @@ -237,7 +236,5 @@
>          COM_INTERFACE_ENTRY_IID(IID_IShellChangeNotify, IShellChangeNotify)
>          COM_INTERFACE_ENTRY_IID(IID_IObjectWithSite, IObjectWithSite)
>          COM_INTERFACE_ENTRY_IID(IID_IServiceProvider, IServiceProvider)
> -        COM_INTERFACE_ENTRY_IID(IID_IWinEventHandler, IWinEventHandler)
> -        COM_INTERFACE_ENTRY_IID(IID_IBandSite, IBandSite)
>      END_COM_MAP()
>  };
> 
> 


-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.reactos.org/pipermail/ros-dev/attachments/20150629/5850be0c/attachment-0001.html>