[ros-dev] [ros-diffs] [tfaber] 64695: [ROSAUTOTEST] - DbgPrint expects a format string! ROSTESTS-145 #resolve

Colin Finck colin at reactos.org
Sun Oct 12 19:37:44 UTC 2014


tfaber at svn.reactos.org wrote:
> -                DbgPrint(DbgString);
> +                OutputDebugStringA(DbgString);

FYI, we had OutputDebugStringA there in the first place, but I changed
it to DbgPrint in r40147.
IIRC, output from DbgPrint was directly sent to the debug port while
OutputDebugStringA buffers the data first. This is especially bad, when
a test crashes the OS and we lose several kilobytes of log data before
they are printed out.

Probably, a DbgPrint("%s", DbgString) is the better alternative here.


- Colin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3740 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://www.reactos.org/pipermail/ros-dev/attachments/20141012/4fc68fe6/attachment.bin>


More information about the Ros-dev mailing list