[ros-dev] [ros-diffs] [jgardou] 65388: [TCPIP] - Comment out an optimisation which doesn't work. Reviews of why would be most appreciated.

[Timo Kreuzer]

tcpip.c:264

     /* Keep this list sorted */
     InsertHeadList(ListEntry, &OutInstance->ListEntry);

This should probably be InsertTailList(), since you want to insert 
before the current ListEntry


Am 12.11.2014 12:39, schrieb jgardou at svn.reactos.org:
> Author: jgardou
> Date: Wed Nov 12 11:39:13 2014
> New Revision: 65388
>
> URL: http://svn.reactos.org/svn/reactos?rev=65388&view=rev
> Log:
> [TCPIP]
>   - Comment out an optimisation which doesn't work.
> Reviews of why would be most appreciated.
>
> Modified:
>      branches/tcpip_revolution/drivers/network/tcpip/entities.c
>
> Modified: branches/tcpip_revolution/drivers/network/tcpip/entities.c
> URL: http://svn.reactos.org/svn/reactos/branches/tcpip_revolution/drivers/network/tcpip/entities.c?rev=65388&r1=65387&r2=65388&view=diff
> ==============================================================================
> --- branches/tcpip_revolution/drivers/network/tcpip/entities.c	[iso-8859-1] (original)
> +++ branches/tcpip_revolution/drivers/network/tcpip/entities.c	[iso-8859-1] Wed Nov 12 11:39:13 2014
> @@ -309,9 +309,11 @@
>               return STATUS_SUCCESS;
>           }
>   
> +#if 0
>           /* The list is sorted, so we can cut the loop a bit */
>           if (ID.tei_instance < Instance->InstanceId.tei_instance)
>               break;
> +#endif
>   
>           ListEntry = ListEntry->Flink;
>       }
>
>
>