[ros-dev] [ros-diffs] [cwittich] 63452: [bootdata] converthivecls.inf and hivedef.inf to UTF16LE fixes CORE-7614

[Colin Finck]

Christoph von Wittich wrote:
> Did you notice the mime type I set?

"text/plain;charset=UTF-16" looks cool, didn't know about this one.
Still, it doesn't make patching any better. I just had a try with
command-line SVN 1.7.9: Changing hivedef.inf a bit, doing "svn diff >
diff.patch", reverting hivedef.inf again and trying "svn patch
diff.patch". The resulting hivedef.inf was totally garbage.

With such bad UTF-16 support for basic tasks, I still don't consider
this a solution. Let's better stick to UTF-8 for these files and convert
them to UTF-16 on the fly. This also denotes the UTF-16 critical files
in the build files.

Matthias has written the utf16le tool for this years ago, it just needs
a simple rule in CMake. Would anybody volunteer?


- Colin