[ros-dev] [ros-diffs] [cwittich] 63423: [shell32] revert one line of r63414

[Thomas Faber]

I don't understand. Wine seems to have it right.

 341     if (!(psei->fMask & SEE_MASK_NO_CONSOLE))
 342         dwCreationFlags |= CREATE_NEW_CONSOLE;

http://source.winehq.org/git/wine.git/blob/ee13e10cf6d05c7d08dfebb9f04c70eb3e7a0a9e:/dlls/shell32/shlexec.c#l341


On 2014-05-24 14:13, Christoph von Wittich wrote:
> This should be send to wine then.
> 
> -----Ursprüngliche Nachricht-----
> Von: Ros-dev [mailto:ros-dev-bounces at reactos.org] Im Auftrag von Thomas
> Faber
> Gesendet: Samstag, 24. Mai 2014 11:03
> An: ros-dev at reactos.org
> Betreff: Re: [ros-dev] [ros-diffs] [cwittich] 63423: [shell32] revert one
> line of r63414
> 
>> --- trunk/reactos/dll/win32/shell32/shlexec.cpp	[iso-8859-1]
> (original)
>> +++ trunk/reactos/dll/win32/shell32/shlexec.cpp	[iso-8859-1] Fri May
> 23 17:14:39 2014
>> @@ -459,7 +459,7 @@
>>      startup.dwFlags = STARTF_USESHOWWINDOW;
>>      startup.wShowWindow = psei->nShow;
>>      dwCreationFlags = CREATE_UNICODE_ENVIRONMENT;
>> -    if (!(psei->fMask & SEE_MASK_NO_CONSOLE))
>> +    if (psei->fMask & SEE_MASK_NO_CONSOLE)
>>          dwCreationFlags |= CREATE_NEW_CONSOLE;    
>>      startup.lpTitle = (LPWSTR)(psei->fMask & (SEE_MASK_HASLINKNAME |
> SEE_MASK_HASTITLE) ? psei->lpClass : NULL);
> 
> 
> This is the opposite of what the documentation says?