[ros-dev] r58367 - Fix a bug in StartupWindowThread

[Aleksey Bragin]

Hi,
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msgina/gui.c?r1=58367&r2=58366&pathrev=58367
Is there a point in that DuplicateHandle call?

"When SetThreadDesktop is called the system closes the desktop handle 
when needed
so we have to create a new handle because this handle may still be in 
use by winlogon"

Sorry, I re-read that comment a few times and still can't understand. I 
take it that SetThreadDesktop closes the old handle which was set 
before. And it may, for some reason, be used by winlogon. Shouldn't that 
be a place to fix, rather than the hack in r58367?

And why is the SetThreadDesktop(OldDesk) is removed by this revision?

Regards,
Aleksey Bragin